The latest @nrwl/* versions using the latest @angular-devkit/* and @angular/compiler* versions.
@nrwl/* libraries are still relying on @angular-devkit/* 0.801.1 and 8.1.1 is 22 days old and 8.1.3 is out and should not have breaking-changes right? 8.2.0 was released just before 8.4.2.
Is there a reason for them not to be peer dependencies? I keep having duplicates in my node modules <.<
@matheo does it cause any issues?
@vsavkin it just duplicates dependencies and keeps "outdated" versions in our projects, not a big deal but I wonder if you guys have a policy about fixing those versions instead using the latest patch like ~0.801.1 which later in that month will be able to use the 0.801.3 release, or use peerDependencies as inside an Angular repo we may have them already installed.
@matheo the devkit wasn't very stable at one point, so Nx got broken by the latest patch. That's the main reason why the dependencies are set up the way they are. The devkit is more stable now though. So we can reconsider.
We aren't planning to make them peer deps because it will introduce unnecessary coupling.
@vsavkin as the time goes on, we're getting more warnings while updating:
warning "@nrwl/node > @nrwl/linter > @angular/[email protected]"
has incorrect peer dependency "typescript@>=3.4 <3.5".
warning "@nrwl/node > @nrwl/linter > @angular-devkit/[email protected]"
has incorrect peer dependency "typescript@>=3.1 < 3.5".
warning "@nrwl/node > @nrwl/linter > @angular-devkit/build-angular > @ngtools/[email protected]"
has incorrect peer dependency "typescript@>=3.4 < 3.5".
@matheo There is a PR https://github.com/nrwl/nx/pull/1757 coming. Soon I hope :)
Thanks for the info @mehrad-rafigh!
Closing this issue. The deps have been updated.
Most helpful comment
Is there a reason for them not to be peer dependencies? I keep having duplicates in my node modules <.<