Nx: feat(ngrx): support createAction

Created on 5 Apr 2019  路  4Comments  路  Source: nrwl/nx

In the latest version of NgRx (7.4.0), createAction seems to become a standard way to create actions (example here), so it would be awesome if Nx could support this version update :heart: :relaxed:.

enhancement
Source
picture hadrien-toma
👍8

Most helpful comment

@hadrien-toma Yup. We should update it. It would be great if you could submit a PR making the change?

picture vsavkin on 14 Apr 2019
👍2

All 4 comments

@hadrien-toma Yup. We should update it. It would be great if you could submit a PR making the change?

vsavkin picture vsavkin on 14 Apr 2019
👍2

@vsavkin Not sure I am experienced enough to but I will try in next weeks I hope so 馃.

hadrien-toma picture hadrien-toma on 14 Apr 2019

Hey @vsavkin and @FrozenPandaz I come back to this issue now that the NgRx v8 is nearly released. Is the update into the Nx repo affected to someone? I think I can now handle it if you give me some pointers.

hadrien-toma picture hadrien-toma on 1 Jun 2019

@vsavkin @FrozenPandaz may we close this issue? According to https://github.com/nrwl/nx/commit/6516176 Nx 8.3.0 seems to be compliant with NgRx 8 馃槏.

hadrien-toma picture hadrien-toma on 24 Jul 2019
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

about-code picture about-code  路  3Comments
vimalraj-a picture vimalraj-a  路  3Comments
elliotmendiola picture elliotmendiola  路  3Comments
Svancara picture Svancara  路  3Comments
Koslun picture Koslun  路  3Comments