Nx: why ViewEncapsulation.None

Created on 11 Dec 2017  路  3Comments  路  Source: nrwl/nx

A question: why have you chosen to use ViewEncapsulation.None in your schematics? This loses the capability to restrict class styles to a per component basis?

bug

Most helpful comment

I agree (especially since NX creates a monorepo containing any number of components whose styles could collide with one another). where style collisions . I think that we should default to using ViewEncapsulation.Emulated personally

All 3 comments

I agree (especially since NX creates a monorepo containing any number of components whose styles could collide with one another). where style collisions . I think that we should default to using ViewEncapsulation.Emulated personally

I think this came over from a copy of the schematics option from the Angular CLI at the time when that was configured in there as a default (something that has been fixed in the Angular CLI). We just need to update the Nx schematic to remove that "default": "None" property.

https://github.com/nrwl/nx/blob/master/packages/schematics/src/collection/app/schema.json#L40

From what I've experienced, it only places the ViewEncapsulation.None on the app.component.ts in the root of each of your apps.

Was this page helpful?
0 / 5 - 0 ratings