Nvim-treesitter: smart_rename fails for multiple replacements in the same line

[dominiklohmann]

Describe the bug
smart_rename does not work correctly when replacing the same variable multiple times in the same row, iff the desired variable name is of different length than the original variable name.

To Reproduce
Consider this code:

template <class Functor>
auto inspect(Functor& f, value& ec) {
  return f(ec.a, ec.b);
}

Use smart_rename to rename ec to x.

This is the result:

template <class Functor>
auto inspect(Functor& f, value& x) {
  return f(x.a, exb);
}

Expected behavior

template <class Functor>
auto inspect(Functor& f, value& x) {
  return f(x.a, x.b);
}

Output of :checkhealth nvim_treesitter

health#nvim_treesitter#check

Installation

• OK: git executable found.
• OK: cc executable found.

html parser healthcheck

• OK: html parser found.
• OK: highlights.scm found.
• WARNING: No locals.scm query found for html
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for html
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

typescript parser healthcheck

• OK: typescript parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• WARNING: No textobjects.scm query found for typescript
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

markdown parser healthcheck

• OK: markdown parser found.
• WARNING: No highlights.scm query found for markdown
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for markdown
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for markdown
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

regex parser healthcheck

• OK: regex parser found.
• OK: highlights.scm found.
• WARNING: No locals.scm query found for regex
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for regex
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

c parser healthcheck

• OK: c parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• OK: textobjects.scm found.

nix parser healthcheck

• OK: nix parser found.
• WARNING: No highlights.scm query found for nix
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for nix
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for nix
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

swift parser healthcheck

• OK: swift parser found.
• WARNING: No highlights.scm query found for swift
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for swift
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for swift
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

java parser healthcheck

• OK: java parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• WARNING: No textobjects.scm query found for java
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

python parser healthcheck

• OK: python parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• OK: textobjects.scm found.

yaml parser healthcheck

• OK: yaml parser found.
• WARNING: No highlights.scm query found for yaml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for yaml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for yaml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

elm parser healthcheck

• OK: elm parser found.
• WARNING: No highlights.scm query found for elm
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for elm
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for elm
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

vue parser healthcheck

• OK: vue parser found.
• WARNING: No highlights.scm query found for vue
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for vue
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for vue
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

cpp parser healthcheck

• OK: cpp parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• OK: textobjects.scm found.

toml parser healthcheck

• OK: toml parser found.
• WARNING: No highlights.scm query found for toml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for toml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for toml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

lua parser healthcheck

• OK: lua parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• WARNING: No textobjects.scm query found for lua
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

ruby parser healthcheck

• OK: ruby parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• WARNING: No textobjects.scm query found for ruby
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

ocaml parser healthcheck

• OK: ocaml parser found.
• WARNING: No highlights.scm query found for ocaml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for ocaml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for ocaml
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

go parser healthcheck

• OK: go parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• OK: textobjects.scm found.

scala parser healthcheck

• OK: scala parser found.
• WARNING: No highlights.scm query found for scala
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for scala
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for scala
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

haskell parser healthcheck

• OK: haskell parser found.
• WARNING: No highlights.scm query found for haskell
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for haskell
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for haskell
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

rust parser healthcheck

• OK: rust parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• OK: textobjects.scm found.

json parser healthcheck

• OK: json parser found.
• OK: highlights.scm found.
• WARNING: No locals.scm query found for json
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for json
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

jsdoc parser healthcheck

• OK: jsdoc parser found.
• WARNING: No highlights.scm query found for jsdoc
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for jsdoc
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for jsdoc
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

javascript parser healthcheck

• OK: javascript parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• WARNING: No textobjects.scm query found for javascript
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

css parser healthcheck

• OK: css parser found.
• OK: highlights.scm found.
• WARNING: No locals.scm query found for css
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for css
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

julia parser healthcheck

• OK: julia parser found.
• WARNING: No highlights.scm query found for julia
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for julia
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for julia
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

php parser healthcheck

• OK: php parser found.
• WARNING: No highlights.scm query found for php
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for php
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for php
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

c_sharp parser healthcheck

• OK: c_sharp parser found.
• WARNING: No highlights.scm query found for c_sharp
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No locals.scm query found for c_sharp
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  
• WARNING: No textobjects.scm query found for c_sharp
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

bash parser healthcheck

• OK: bash parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• WARNING: No textobjects.scm query found for bash
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

tsx parser healthcheck

• OK: tsx parser found.
• OK: highlights.scm found.
• OK: locals.scm found.
• WARNING: No textobjects.scm query found for tsx
  
  
  
  • ADVICE:
    
    
    
    
    
    • Open an issue at https://github.com/nvim-treesitter/nvim-treesitter
    
    
    
  
  

Output of nvim --version

❯ nvim --version
NVIM v0.5.0-nightly-217-g950ca6abc
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNDEBUG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/tmp/neovim-20200720-14610-1xe0vle/build/config -I/tmp/neovim-20200720-14610-1xe0vle/src -I/usr/local/include -I/tmp/neovim-20200720-14610-1xe0vle/deps-build/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX10.16.sdk/usr/include -I/usr/local/opt/gettext/include -I/tmp/neovim-20200720-14610-1xe0vle/build/src/nvim/auto -I/tmp/neovim-20200720-14610-1xe0vle/build/include
Compiled by dominiklohmann@amethyst

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/HEAD-950ca6a/share/nvim"

Run :checkhealth for more info

[vigoux]

Hi ! thanks for reporting that ! That's actually a bug ! I think I know how this should be fixed (no time now though) !

[vigoux]

@steelsojka didn't you have a similar problem once ?

[theHamsta]

@steelsojka has already some experience with lsp applyTextEdits

[theHamsta]

Ok, I think I already implemented it @steelsojka

[theHamsta]

Could you please test #207 ? @dominiklohmann I will have a look on my PR tomorrow. I just coded in really fast and need to check it again.

Sorry, there's still a bug in the fix.
Should be ok now.

[dominiklohmann]

I can confirm your PR fixes the issue for me.