Numeral-js: twice locale Registration issue

[kinguru]

Hi,

Why second Locale registration throws an excpetion?
My scenarion: I need dynamically update Locale by ajax. How I can do it in current codebase?

Thank you.

[fluse]

i have the same problem, please remove following line:

https://github.com/adamwdraper/Numeral-js/blob/master/src/numeral.js#L468

[acarl]

I agree that this is an issue.
In the mean time I worked around it by just checking to see if it exists first.

if (numeral.locales['user-locale'] === undefined) {
  numeral.register('locale', 'user-locale', {});
}

[RaulTsc]

......... this is really not fixed yet? Why would anyone want to throw? Just overwrite it.

[Softie42]

The workaround above works for me in react. Thanks.

[jeancabral]

The workaround works for me too

[ZaidQ797]

I agree that this is an issue.
In the mean time I worked around it by just checking to see if it exists first.

if (numeral.locales['user-locale'] === undefined) {
  numeral.register('locale', 'user-locale', {});
}

thanks, buddy it worked!!!