Nteract: Add missing dependencies to our packages

Created on 20 Oct 2018  ยท  4Comments  ยท  Source: nteract/nteract

One of the inherit problems when developing packages in a monorepo is that it's easy to forget to include all necessary dependencies in the respective package.json files. This often leads to bugs when people are trying to use our packages outside the context of the monorepo.

We should enforce proper declaration of dependencies by adding the import/no-extraneous-dependencies ESLINT rule to the repo and fix the issues it catches.
For this we probably need to ignore our __test__ directories since, dev dependencies are currently declared in the root package.json.

Note: One convention we currently follow is to require react, react-dom and immutable as peerDependencies rather than dependencies.

hacktoberfest mentoring-available new-contributor-friendly outdated stale

Most helpful comment

I'd love to take a crack at this if that's alright

All 4 comments

I'd love to take a crack at this if that's alright

I'd love to take a crack at this if that's alright

That's awesome!

You might want to checkout #3472 since it already adds the plugin as a dependency. Thus you'd only need to add the rule to the config to get started.

@jamessral #3472 is now merged into master, all set to go ๐ŸŽ‰

This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed.
It's more than likely that just by me posting about this, the maintainers will take a closer look at these long forgotten issues to help evaluate what to do next.
If you would like to see this issue get prioritized over others, there are multiple avenues ๐Ÿ—“:

  • Ask how you can help with this issue ๐Ÿ‘ฉ๐Ÿฟโ€๐Ÿ’ป๐Ÿ‘จ๐Ÿปโ€๐Ÿ’ป
  • Help solve other issues the team is currently working on ๐Ÿ‘จ๐Ÿพโ€๐Ÿ’ป๐Ÿ‘ฉ๐Ÿผโ€๐Ÿ’ป
  • Donate to nteract so we can support developers to work on these features and bugs more regularly ๐Ÿ’ฐ๐Ÿ•

Thank you!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bionicles picture bionicles  ยท  3Comments

jameskoch picture jameskoch  ยท  3Comments

rgbkrk picture rgbkrk  ยท  4Comments

captainsafia picture captainsafia  ยท  5Comments

davidanthoff picture davidanthoff  ยท  4Comments