NSwagStudio v12.1.0.0 mis-generates `FileResponse` for regular response model

[dmitry-pavlov]

@RicoSuter - NSwagStudio v12.1.0.0 mis-generates FileResponse for regular response model definition which points to a C# custom class type.

I can send you swagger.json file to reproduce the bug - ping me at [email protected]

[dmitry-pavlov]

I have downgraded to one of previous versions I had - v12.0.7.0 and it generates response type correctly.

Maybe later versions but before v12.1.0.0 also generate response types right, I didn't check that.

[RicoSuter]

Probably a regression of this commit: https://github.com/RicoSuter/NSwag/commit/85c5c2bfe4ede6c216246702e40cd6dd3b6e26a1

[RicoSuter]

v12.0.17+

[RicoSuter]

Is this a duplicate of https://github.com/RicoSuter/NSwag/issues/2080 ?

[DanielGunnars]

Is this a duplicate of #2080 ?

I don't think so, I'm also experiencing this after fixing 2080.

[RicoSuter]

We need more details, eg a part of a swagger spec for the broken operation. Pretty sure it is a problem with the consumes/produces property.

[dmitry-pavlov]

I have just sent the spec to [email protected]

[ljvanschie]

We're having the same issue. The Swagger spec defines the response as "produces": ["*/*"], which causes NSwag to think it produces binary content.

In previous versions, this would be treated as json responses.

[ljvanschie]

Also, "produces": ["application/json;charset=UTF-8"] makes NSwag think it returns binary content instead of json. It looks like file responses are the default/fallback now, whereas before it would default to json.

[RicoSuter]

It looks like file responses are the default/fallback now, whereas before it would default to json.

Exactly, this is the regression - will check soon

[RicoSuter]

Created a PR, please review...

[Thieund]

I encountered the this issue with v13.6.1 & v13.6.2

[jeremyVignelles]

@Thieund is that the same issue as #2892 ?

[Thieund]

@Thieund is that the same issue as #2892 ?

No. I'm returning a file, whether with type "file" or "byte", Promise< FileResponse > is generated, but FileResponse is missing. I'm using TypeScript client, openApi 3.0.1

[Szymek364]

I have the same issue in version 13.6.2.0

[jeremyVignelles]

@Thieund @Szymek364 : Please open new issues then. We need a sample code (hosted on github) that reproduces the issue to investigate.