Nswag: Line endings

[Cephei]

I'm trying to fork this repo and contribute to several bug fixes but as soon as git checks-out all the files, there's about 14-24 files that always report as changed. It's due to line endings but I can't find a solution. A git reset --hard doesn't fix the problem.

I'm building from a Windows environment.

[Cephei]

Most of the files "changed" are .config and .bat.

[RicoSuter]

Yes, I had some problems with line endings (mostly because .tt files require crlf). Please get the latest commit and report if this is still a problem

[grovesNL]

@rsuter I think we may want to normalize all line endings to match the changes to .gitattributes, i.e. https://help.github.com/articles/dealing-with-line-endings/#refreshing-a-repository-after-changing-line-endings

[Cephei]

Re-forked and worked perfectly! Thanks!

[RicoSuter]

@grovesNL thanks, will do that soon...

[RicoSuter]

Ok, it should be fine now...

https://github.com/NSwag/NSwag/commit/84ea8fc86fb9e0d9b74948a76560208527de23af

[Cephei]

This is still a major issue. I'm having all kinds of problems with .ts, .tt, .csproj.

[Cephei]

Also, anything generated by .tt should most likely not be checked into the repo. It should be ignored by git. I'm running build.bat to test integration and then it shows me all the files to be checked in.

[RicoSuter]

Please try to delete the local repo and clone it again...

[Cephei]

I just created an entirely new fork. Deleted all files prior. Still shows files changed.

[RicoSuter]

Had the same problem, commited the changes: https://github.com/NSwag/NSwag/commit/34effb4a68c526592dc1c1ca986770e2c5859a59

Does this fix your problem?

[Cephei]

unsure ... I ran git rm --cached -r . and then git reset --hard. It seemed to help.

[grovesNL]

I noticed this yesterday too. It seems as though some files were skipped in the correction (https://github.com/NSwag/NSwag/commit/84ea8fc86fb9e0d9b74948a76560208527de23af) for some reason.

Fortunately after all the files have the correct line endings (i.e. matching .gitattributes rules) we shouldn't have this problem again. We just have to make sure any existing branches run git rm --cached -r . and git reset --hard as @Cephei said.

[Cephei]

These files must be getting generated from Demo.Web. Keeps asking me to check them in after a build. Going to disable that project (locally) for now.