Nservicebus: Simplify API for providing endpoint instance ID

[SzymonPobiega]

This issue is a replacement for #3406 . For now we agreed to provide simple API like

config.InstanceId(string id);

• [ ] Core change
• [ ] Doco update
• [ ] Compatibility tests update

[SzymonPobiega]

@Particular/tf-v6-launch-plat-dev please mark it as 'V6' since we can't ship it with the old config.ScaleOut().InstanceDiscriminator() API.

[andreasohlund]

Flagged as Consider for v6

[bording]

FYI, #3654 has introduced another place in the code where the old API has been referenced in an exception message.

[SeanFeldman]

@SzymonPobiega added compatibility tests to the check-list

[SzymonPobiega]

Thanks @bording & @SeanFeldman :)

[tmasternak]

It looks that this can be address as a minor release. In addition this seems to be advanced api so users should be able to cope with what we have right now.

/cc: @danielmarbach @boblangley

[bording]

@tmasternak I wouldn't really consider this an advanced API. You have to use it to enable Callbacks, for example.

The current config.ScaleOut().InstanceDiscriminator() API makes this a very bizarre API that you'd need to call just get to get Callbacks working.

[SzymonPobiega]

@tmasternak I don't think we can address it in minor because this is a braking change to the public API.

[johnsimons]

@SzymonPobiega looking at this, I agree with @tmasternak, it seems all you need to do is introduce the new API in a minor release and deprecate the old one, this is how we usually manage this kind of api changes.
Yes I agree that the current API is not very intuitive, so is config.InstanceId(string id); better ? I am not sure!

[SzymonPobiega]

@johnsimons ok, I am ok with this approach.

[tmasternak]

@SzymonPobiega that was the intention. Keep the current API but in minor add a more convenient one.

[tmasternak]

@SzymonPobiega that was the intention. Keep the current API but in minor add a more convenient one.

[timbussmann]

the v6 release changed the config.ScaleOut().UniqueQueuePerEndpointInstance() to endpointConfiguration.MakeInstanceUniquelyAddressable. Since there was no progress on this issue and no clear steps forward, we're going to close this. Feel free to reopen if we missed something or you think there is still an important task outstanding.