Np: Doesn't open Github release notes when using arguments
Description
When passing in arguments (eg. np minor) it skips the UI (which is the part that determines the repoUrl) and consequently skips the 'Creating release draft on GitHub' task.
Steps to reproduce
- Setup a Github repo
npx np minor- Don't see publish draft page
Expected behavior
- For the publish draft to open
privatenumber
👍1
All 2 comments
Looking at ui.js, I think we should move the releaseNotes creation into a separate file, and extract the repoUrl detection from it (the detection should be done when using np programmatically as well, but I'm not sure what's the best way to organize this).
It seems like ui.js currently contains lots of functionality that is outside of its scope (as it belongs to the general scope of np), which should be separated from it to keep it single-purposed and maintainable.
itaisteinherz
on 26 Mar 2019
👍2
I think this is fixed by https://github.com/sindresorhus/np/pull/378
fregante
on 9 Apr 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings
Related issues
voxpelli
路
5Comments
gillesdemey
路
3Comments
janpio
路
6Comments
nickthesing
路
5Comments
jescalan
路
3Comments
Most helpful comment
Looking at
ui.js, I think we should move thereleaseNotescreation into a separate file, and extract therepoUrldetection from it (the detection should be done when usingnpprogrammatically as well, but I'm not sure what's the best way to organize this).It seems like
ui.jscurrently contains lots of functionality that is outside of its scope (as it belongs to the general scope ofnp), which should be separated from it to keep it single-purposed and maintainable.