Notebook: Long completions: e.g. path

Created on 7 Aug 2015 · 12Comments · Source: jupyter/notebook

Can the path completion with tab be changed so that you do not always see the complete path so far in the pop-up, but only the further options? With long paths, the end of the path (which then contains the files I need to choose from) fall off the screen or I have to start scrolling.

Enhancement

Source

kehey

All 12 comments

@kehey : We're doing a little housekeeping on our issue log and I noticed this thread from 2015. Has this issue been resolved to your satisfaction and can it be closed? thanks!

JamiesHQ on 25 Apr 2017

I'm not sure it was ever resolved... Unless it was done in the last version that I haven't updated to yet.

kehey on 25 Apr 2017

@gnestor : was this resolved in the 5.0 release? thanks!

JamiesHQ on 25 Apr 2017

This is what I currently see in notebook 5.0.0:

Can the path completion with tab be changed so that you do not always see the complete path so far in the pop-up, but only the further options?

It appears like it's working as you would expect now. I'm going to close this but feel free to re-open if need be...

gnestor on 25 Apr 2017

That GIF still looks like the issue that was reported, AIUI. If this was fixed, the last time you summon the tab-completer dropdown, it would only show you the filenames, like victory.ipynb, instead of ./jupyterlab_react/victory.ipynb.

takluyver on 25 Apr 2017

Oh, I see. Ok, let's re-open and mark as contributor-friendly.

gnestor on 25 Apr 2017

👍1

I'd like to take a look at this one. Any objections?

zmackie on 9 Jun 2017

👍1

@Zanadar By all means!!

gnestor on 9 Jun 2017

🎉1

@Zanadar Any luck with this one?

@takluyver What do you suggest for this one? How do we classify a completion match as a path vs. not a path? If they are a path, remove /.+\//?

gnestor on 7 Dec 2017

I'm not sure that anything related to calculating completions really belongs under the 'good first issue' tag, unfortunately.

The code in question is in IPython. The function for finding file completions is here:

https://github.com/ipython/ipython/blob/cefab40bb755260ddec63efc24d8e1ea3b6fba06/IPython/core/completer.py#L1133

But it's a mess of regexes and special cases.

takluyver on 7 Dec 2017

I have created an issue on ipython for this. I'll take a stab at it...

gnestor on 7 Dec 2017

I tried implementing this in the notebook and one of the issues with trimming the full path for display in the completer is that when you select a completion suggestion (press ENTER or click on it), it replaces what you were typing with an incomplete path: