Notebook: Find and replace feature in edit mode - garbled text overwriting entry boxes

[willingc]

See report in jupyter/jupyter (https://github.com/jupyter/jupyter/issues/104).

Find and replace works in the notebook mode.

In edit mode of a .py file, the dialog entry box for find and replace is overwritten with stray text:

To replicate,

1. File->Open a .py file
2. Edit->Find & Replace

Versions: 4.1, 4.0 verified to have the issue.

[willingc]

Additional note: The issue is found in any of the key map settings. I looked at the console and didn't see any errors.

FYI @oeway @dsblank

[oeway]

Additional comment on this "find/replace" feature:

When the find/replace bar appeared, and I typed some word to find, I expect the bar keep still in place, so I can press enter to find the next word, just like you search a word in a webpage with google chrome.

Is there any shortcut to continue the searching? If possible, I think it's more natural to keep the bar, and keep the focus on the bar, when you press enter, it jump to another hit, and if you press escape button, the bar disappear.

[Carreau]

This search replace is just the Codemirror search and replace, we just added a menu.

Our css might conflict, but all other feature/keyboard/bug are likely codemirror ones.

[stonefly]

.CodeMirror {
    line-height: @code_line_height;  /* Changed from 1em to our global default */
    font-size: @notebook_font_size;
    height: auto;     /* Changed to auto to autogrow */
    background: none;  /* Changed from white to allow our bg to show through */
}

it's because of the last line (background: none;)

[takluyver]

Anybody want to try tackling this for 5.0?

[Carreau]

Anybody want to try tackling this for 5.0?

That's typically where I have the new labelling scheme. GitHub has a Standard "Need Contributor" label which is standard across 99 % of GitHub repo, and that you can't add here. You have to add the "cat:new Contributor" which you can't search across repo and make issue like this one less discoverable.

[takluyver]

OK, if we're saying it's an issue for a new contributor, I'm bumping it to backlog.

[willingc]

GitHub has a Standard "Need Contributor" label which is standard across 99 % of GitHub repo, and that you can't add here. You have to add the "cat:new Contributor" which you can't search across repo and make issue like this one less discoverable.

I agree that this labeling approach does not make it easy for new contributors to find issues. I would recommend using the standard New Contributor label and give it a distinct color from the others. It would be fine to keep the cat:New Contributor label as well for reports, etc. So a new contributor issue would be tagged with New Contributor in a distinct color and cat:new Contributor. cc/ @ellisonbg

[ellisonbg]

I am fine using a global "New Contributor" label across all our repos
(without the "cat" prefix). But that is different from "Need Contributor"
which is closer to what we are calling Help Wanted.

On Wed, Feb 1, 2017 at 6:27 AM, Carol Willing [e-mail]
wrote:

GitHub has a Standard "Need Contributor" label which is standard across 99
% of GitHub repo, and that you can't add here. You have to add the "cat:new
Contributor" which you can't search across repo and make issue like this
one less discoverable.

I agree that this labeling approach does not make it easy for new
contributors to find issues. I would recommend using the standard New
Contributor label and give it a distinct color from the others. It would be
fine to keep the cat:New Contributor label as well for reports, etc. So a
new contributor issue would be tagged with New Contributor in a distinct
color and cat:new Contributor. cc/ @ellisonbg
https://github.com/ellisonbg

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/notebook/issues/1045#issuecomment-276670464,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABr0BRm-JCuLY5EOkKuODXzV3KMlBTKks5rYJZpgaJpZM4HTlT6
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]

[Sheshtawy]

Hi! If no one is working on this issue, can I give it a shot?

[Sheshtawy]

Great! I'll start working on it then (@willingc I'm considering your thumbs up as a yes :sweat_smile: )

[willingc]

Go ahead and give it a shot @Sheshtawy.

[Sheshtawy]

@willingc I fixed the styling issue, but I'm having problems making the tests pass locally or on Travis. They've been failing even before I made any changes in the code, and I'm pretty sure the part I touched has nothing to do with the test. If there's something that I can do to make the build succeed on Travis at least please let me know. I'd be happy to work on making sure that all tests pass but I'm not sure if it's within the context of this issue

[takluyver]

Not sure what was happening on Travis, but it looked unlikely that it was related to your change. I've restarted them to find out.

[takluyver]

Oh no, wait, I forgot - the problem is that you've made the PR against the old 4.0.x branch. You'll need to make a new PR against master.

[Sheshtawy]

@takluyver thanks for taking the time to check my PR. I changed the base of the PR to master but there's a lot of merge conflicts. As far as I understand the bug only exists in 4.0 and 4.1 so I branched out from 4.0.x since that where I could reproduce the bug. the master doesn't have this bug (I believe since it's at version 5 now) I couldn't reproduce it when I installed notebook from the master branch

I would really appreciate if you have any recommendation to make the PR ready to merge

[takluyver]

If it's definitely fixed in more recent versions, there's nothing to do,
and we should just close the issue. Sorry for the confusion. Have you
checked yourself that the problem is gone in newer versions, or were you
getting that from someone else?

On Sat, 17 Mar 2018, 1:29 a.m. Hisham Elsheshtawy, [e-mail]
wrote:

@takluyver https://github.com/takluyver thanks for taking the time to
check my PR. I changed the base of the PR to master but there's a lot of
merge conflicts. As far as I understand the bug only exists in 4.0 and 4.1
so I branched out from 4.0.x since that where I could reproduce the bug.
the master doesn't have this bug (I believe since it's at version 5 now) I
couldn't reproduce it when I installed notebook from the master branch

I would really appreciate if you have any recommendation to make the PR
ready to merge

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/notebook/issues/1045#issuecomment-373884004,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUA9WDlatIWAKMQlD8w4Q-1Kq5LgqhVks5tfGcRgaJpZM4HTlT6
.

[Sheshtawy]

I checked the latest version and it's fixed there. I believe there's no need for this issue/PR then :)

I'll try to find another issue to help with. Thanks a lot guys for checking my PR and being so responsive

[Sheshtawy]

I checked issue #3335 and I'm more than happy to start working on it if no one is

[takluyver]

Thanks, and sorry for the misleading issue!