Nomad: Use os.ErrDeadlineExceeded in tests

Created on 9 Sep 2020  路  3Comments  路  Source: hashicorp/nomad

As of Go 1.15 we can now check an error against os.ErrDeadlineExceeded instead of this helper func: https://github.com/hashicorp/nomad/blob/v0.12.3/testutil/net.go

That helper func should be removed.

stagaccepted staggood first issue themcleanup themtesting
Source
picture schmichael

All 3 comments

i've started work on this one 馃帀

loadstar81 picture loadstar81 on 3 Oct 2020
👍1

@loadstar81 are still working on this? If not, I have a patch ready I would submit.

roccoblues picture roccoblues on 4 Dec 2020
👀1

@loadstar81 are still working on this? If not, I have a patch ready I would submit.

@roccoblues nope, it fell off the list :/

go for it!

loadstar81 picture loadstar81 on 4 Dec 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Smuerdt picture Smuerdt  路  3Comments
Gerrrr picture Gerrrr  路  3Comments
funkytaco picture funkytaco  路  3Comments
hynek picture hynek  路  3Comments
leowmjw picture leowmjw  路  3Comments