Nodemailer: Node engine requirement, version 4 support

[uiteoi]

Since version 3.0.0, nodemailer requires node engine ">=6.0.0", while the previous requirement was ">=0.10.0".

This change was made as part of the last commit which title means it is about the licencing change. As a side note, it would have been better to have a separate commit for this change.

Is it possible to at least support node v4, >=4.0.0" which is considered Active in the Long-Term-Support schedule until 2018-04-01?

Reference: LTS schedule

Thanks for this great project.

[andris9]

Node v4 was missing some stuff that I wanted to use but is hard to polyfill, like the spread operator. You can keep using v2.7 as long as you want if you need support for older versions of Node. The v3.0.0 was not just about license change, it was a major rewrite, you can see most of the changes from the CHANGELOG.

[uiteoi]

Thanks for the quick response.

We currently use Node 4.6 in production so we are not be able to upgrade to Nodemailer v3.

Is the spread operator that critical?

Will you continue to support version 2.7 until its end of life of Node 4 - i.e. 2018-04-01?

[andris9]

Spread operator is not the only difference but yeah, I want to use it. For example consider these two identical examples:

function abc(){
    var args = Array.prototype.slice.call(arguments);
    var cb = args.pop();
    args.unshift('first');
    cb.apply(null, args);
}

and

function abc(...args){
    var cb = args.pop();
    cb('first', ...args);
}

I'll fix any serious issues with Nodemailer v2 for the foreseeable future. By "serious" I mean something that would cause Nodemailer to throw an error so it would cause the application process to exit or a security issue like RCE.

[uiteoi]

I understand the convenience, but for now I have made the choice to continue to support what Node supports. In a bit more than a year it will be over and we will be able to switch to ES6 for server-only code.

Thanks for the continued support of version 2.7.

[frehner]

Forgive me if I missed it, but are the docs for v2 gone now that v3 is released?

I'm in the same boat where I'm using nodemailer:2 because of Node:4 dependency (AWS Lambda), and I wasn't able to find any v2 docs.

Or are the v2 and v3 docs similar enough to be mostly interchangeable?