Nodejs-pubsub: Subscriber/Subscription.close does not support promises

[mgabeler-lee-6rs]

Environment details

• OS: Linux
• Node.js version: 7.5.0
• npm version: 6.3.0
• @google-cloud/pubsub version: 0.19.0

Steps to reproduce

1. Call subscription.close() without a callback argument
2. Expect to receive a promise per documentation
3. No promise is returned

UTSL: The code for the Subscription class calls promisifyAll on its members, but Subscriber, where close is implemented, does not, and so close doesn't actually adhere to its JSdoc.

[stephenplusplus]

Thanks for reporting!

@callmehiphop - I can't find this method in the public-facing docs. Is this intended to be a public method?

P.S. What's "UTSL"?

[mgabeler-lee-6rs]

What's "UTSL"?

Use The Source, Luke!

[callmehiphop]

@stephenplusplus it is, I think when I moved the Subscriber code into a separate class it got lost. So my take away is that we need to promisify the Subscriber object and include a JSDoc tag to make close (and any other public method) show up on the docs.