Nodebestpractices: Revert line-length markdownlint setting

Created on 25 Aug 2019  路  9Comments  路  Source: goldbergyoni/nodebestpractices

https://github.com/goldbergyoni/nodebestpractices/pull/551

The suggestion is to disable ignore the rule MD013 in .operations/.markdownlint.json

Most helpful comment

Perfect, thanks for that!

All 9 comments

Thanks for start the discussion!

I think a linting of md is a big step to forward.

OK. I have a problem with MD013.line_length.

To translate, I need to go to a specific line so that the number of lines matches at the end. Thus, I verify that my translation is up to date. This is one of the important milestones in the quality of the product.

Our languages are so different that we cannot guarantee the same number of lines. So, we will lose one of the quality parameters. It looks like a high price.

If you are interested, I can give a description of the translation process, which requires a minimum of effort and returns high quality.

@oshliaer thanks for bringing this to light - it was something I really didn't anticipate! It is important if it impacts quality - as this was aiming to improve quality 馃槃

Do you see any other issues or was it mainly the change related to MD013?

  • [x] - "default" - I am sure that for all left-handed languages this will most likely be correct
  • [x] - "MD033" - Inline HTML
  • [x] - "MD001" - Header levels should only increment by one level at a time
  • [ ] - "MD013" - Line length. We may have problems for different languages
  • [x] - "MD039" - Spaces inside link text

I checked this for the Russian file. This is basically MD013. To fix this, it will take me several hours and I can not guarantee the set numbers of lines.

Untitled

OK cool. In the next day or so, I will create a PR to revert the line changes to README.md, but retain the other changes

I really hope that I did not cause you any inconvenience or concern.

No, thank you! Good to raise it as an issue early so we can catch the issue

@oshliaer I have created https://github.com/goldbergyoni/nodebestpractices/pull/559 to revert these problematic changes

Thanks for this!

I updated the translation. Now it's on the crest of a wave! :surfing_man:

I think this can be closed.

Perfect, thanks for that!

Was this page helpful?
0 / 5 - 0 ratings