Nodebb: Re-ordering Pinned Topics no longer works

[djensen47]

• NodeBB version: 1.11.1
• NodeBB git hash: b0a44d866b08c1dc8b6d1c37364e8fa4fd21bf34
• Database type: mongo
• Database version: 3.6

• Exact steps to cause this issue:

  1. Visit a category page with a lot of pinned topics
  2. Reorder some of the pinned topics
  3. Navigate away from the category page
  4. Navigate back to that category page

• What you expected:

  • The pinned topics should be in the order that I created.

• What happened instead:

  • The topics are not re-ordered.

[djensen47]

The behavior is inconsistent. On one category, the re-order works fine. On another it doesn't work at all.

[barisusakli]

How many pinned topics are there?

[djensen47]

Broken category has 8:
https://www.axisandallies.org/forums/category/15/website-forum-discussion

The one that works has 5:
https://www.axisandallies.org/forums/category/12/welcome

[djensen47]

Actually, now it's broken for both of those categories.

Maybe the re-order only works the first time?

[barisusakli]

Can you open your network console and post the data sent from the websocket call topics.orderPinnedTopics

[barisusakli]

Sample output from our forum when I order topics

[djensen47]

Here's the output after I move the second one to the first position. It seems correct.

[barisusakli]

And does the topic id and the order match? Or is it showing the wrong id?

[djensen47]

Yes, the order matches.

[barisusakli]

Thanks found the issue.

[djensen47]

Thanks for looking into it and Happy New Year! 🎉

[barisusakli]

@djensen47 Happy new year!

fyi this was happening due to the suggested topics widget having the same pinned topics and the jquery selector was finding those as well. Hence why you have 16 items in the array when you had only 8 pinned topics.