1. new file paths are breaking the coverage reporting
File paths for Node.js' own files now have this form node:/internal/cluster/shared_handle:
node: prefix..js prefix.I will happily fix this problem in the test reporter, but could someone point me towards where these changes were made (_@watilde, @guybedford?_) -- I want to make sure I link to the change in the reporter codebase.
2. nightly coverage is broken again
Coverage has been broken for several nights in a row. I believe this is due to an unrelated CI/CD upgrade?
CC: @nodejs/testing
could someone point me towards where these changes were made
I believe this has been introduced by https://github.com/nodejs/node/pull/35498.
@aduh95 thank you! (_sorry for looping in the wrong folks, I assumed it was potentially the new URL parser)_.
Have we ever tried adding c8 to https://github.com/nodejs/citgm/ ? (I searched for it and I don't think so?)
we should add it, it isn't included right now afaik. For reference this is the lookup table
Have we ever tried adding c8 to https://github.com/nodejs/citgm/ ? (I searched for it and I don't think so?)
@joyeecheung @MylesBorins not a bad idea, but it wouldn't have actually caught this, because it only breaks on Node.js' own coverage -- which now has different file paths (_c8 would continue working for userland._)