nodejs code is too messy

Created on 25 Aug 2020  路  4Comments  路  Source: nodejs/node

Such as node.cc

  1. Mixed use of c and c++ code
  2. The platform-related code is not split into different files
  3. The class is not split into separate files
  4. A lot of macros using various switches
  5. Macros and global variables are not placed at the beginning of the file
  6. Many global static variables are used
    Such code is too difficult to read and maintain

Most helpful comment

Apologies. I will try harder in the future.

All 4 comments

Apologies. I will try harder in the future.

You claim to be a JavaScript project, and yet you are written in C/C++..... Curious.....

I want to embed Node.js into Unreal (just like Unreal.js). I have tried to embed Node.js as a scripting engine into Unity3D before. I modified a lot of code to succeed, far from https://nodejs.org/api/embedding.html document description is as simple
Node.js code is too difficult to understand

As with everything, if you believe specific improvements can be made, pull requests are always welcomed. We tend to try to avoid changes that are purely stylistic or cosmetic in nature, but if they are obvious improvements to maintainability then they can often make progress.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jmichae3 picture jmichae3  路  3Comments

mcollina picture mcollina  路  3Comments

danialkhansari picture danialkhansari  路  3Comments

stevenvachon picture stevenvachon  路  3Comments

dfahlander picture dfahlander  路  3Comments