Node: build: remove GitHub Actions for tarballs?

Created on 29 Jun 2020 · 9Comments · Source: nodejs/node

I could be wrong but it seems to me:

The tarball jobs take a long time to run.
They fail on at least one of Windows or macOS on almost every run on PRs against master.
The output is annoying-at-best to work with efficiently.
It seems that no one is looking in to why they're failing.
It seems that code is landing anyway, despite the failures.

The intention was good, but the end result is not that people are making sure the tarballs build. It's that we're ignoring test failures.

Correction welcome! If these are resulting in activity I'm not seeing, then great! But if not...

Let's disable/remove them?

Source

Trott

👍1

Most helpful comment

This seems as good a place to note this -- until we come up with a better way of representing test results in the actions interface you may find it easier to search through the raw log:

richardlau on 3 Jul 2020

❤2

All 9 comments

To be clear: I'd rather keep the action and get building fixed/reliable. But if we're not going to do that, I'm not excited about having basically permanently failing actions.

Trott on 29 Jun 2020

If they're generally passing on Linux perhaps we could start by removing the macOS/Windows tests rather than remove the whole thing?

* The output is annoying-at-best to work with efficiently.

* It seems that no one is looking in to why they're failing.

* It seems that code is landing anyway, despite the failures.

I feel these three points are general to our GitHub Actions workflows in general and not specific to the tarball workflow.

richardlau on 29 Jun 2020

Related #33947. I'm fine removing or keeping just Linux.

mmarchini on 29 Jun 2020

* They fail on at least one of Windows or macOS on almost every run on PRs against master.

I've sampled a few of the Windows failures and they're all failing parallel/test-vm-timeout-escape-promise-2. I've raised https://github.com/nodejs/node/issues/34163.

richardlau on 1 Jul 2020

I'm still not sure just fixing the test failures will do any good, there are many runs of this action that are hanging/failing with no output (example: https://github.com/nodejs/node/runs/784411094?check_suite_focus=true).

mmarchini on 1 Jul 2020

This seems as good a place to note this -- until we come up with a better way of representing test results in the actions interface you may find it easier to search through the raw log:

richardlau on 3 Jul 2020

❤2

I'd like to prod this again... I really think we should consider removing this action and perhaps re-implementing something in our primary CI