Node: Display process warning stack traces by default

Created on 11 May 2020 · 9Comments · Source: nodejs/node

Is your feature request related to a problem? Please describe.

Recently I've come to an issue, where the author provided only TimeoutOverflowWarning without any stack traces whatsoever, therefore I'm unable to locate the source.

Describe the solution you'd like

I'd propose to enable process warning stack traces by default, so people don't have to node --trace-warnings index.js. There would be another option to disable that, --no-trace-warnings.

good first issue

Source

szmarczak

👍3

Most helpful comment

Sounds good to me. This looks like a good first issue, unless I'm wrong? (I added the label, if anyone things that's not a good first issue feel free to remove it).

mmarchini on 20 May 2020

👍2

All 9 comments

Sounds good to me. This looks like a good first issue, unless I'm wrong? (I added the label, if anyone things that's not a good first issue feel free to remove it).

mmarchini on 20 May 2020

👍2

I would like to take up this issue. Can someone guide me through it as I am a first time contributor and the codebase is huge.
CC @mmarchini

bhumijgupta on 20 May 2020

Gentle ping @mmarchini

bhumijgupta on 25 May 2020

Hey @bhumijgupta, sorry for the delay, I didn't check GitHub during the long weekend. Have you contributed to the project before? If you haven't, I suggest starting by cloning the repository and making sure you can build it. Instructions to build are available in https://www.github.com/nodejs/node/tree/master/BUILDING.md.

mmarchini on 27 May 2020

👍1

@mmarchini I've cloned the repository and built the source code. Willing to take up the issue if @bhumijgupta is not working on it.

preyunk on 27 May 2020

@PreYunk I am working on the issue, although it may take some time for me to land a PR since the codebase and the tests affected by the changes are more in number

bhumijgupta on 27 May 2020

I'm generally -1 on displaying the stack traces by default. Warnings can already be very noisy, particularly deprecation warnings. Making them more noisy likely isn't going to be received well by most users.

jasnell on 27 May 2020

👎1

Warnings can already be very noisy, particularly deprecation warnings.

Then maybe let's deprecate it and hard reject?

szmarczak on 27 May 2020

I think for the small project it makes sense to see the stack traces by default. But as the codebase starts to get larger, modules and other aspects affected by any error or warning increase in number, it becomes very messy as @jasnell mentioned. And generally, people working on larger projects are more experienced to expect any error or warning, so they can include --trace-warnings to see the full stack traces while running a file. So, I think there is no hardcore need to change it.

What do you think?