Node: PR diffs are showing pages of unrelated warnings about "check annotations"

[sam-github]

• Version: ???
• Platform: ???
• Subsystem: ???

Random example from https://github.com/nodejs/node/pull/31337/files: pr31337.pdf

Its not clear what is causing this, but its quite distracting.

Does anyone know? Is it because of github actions?

[richardlau]

These started appearing after we enabled builds using GitHub Actions workflows in https://github.com/nodejs/node/pull/31153.

I attempted to get rid of them in https://github.com/nodejs/node/pull/31311 but it looks like it only shows the first 10 failing checks so the ones I fixed are gone but it's now showing the next 10.

[richardlau]

I think I've figured out what's going on... it just so happens that the warning messages coming out of the Visual Studio C/C++ compiler happen to match the regular expression in the tsc problem matcher installed by the setup-node action we use to run npx envinfo prior to the build.
https://github.com/nodejs/node/blob/f4a4a1a63c7ceba77a0178b4af6068abcadba41f/.github/workflows/CI.yml#L22-L27

I don't see a way to turn off this problem matcher. Not using setup-node would prevent the problem matcher being installed.

cc @gengjiawen

[sam-github]

I don't think the annotations are helpful to collaborators, and I think they may be actively discouraging and confusing to new contributors. Its not an emergency, but if they could be disabled, I think it would be an improvement to the contribution experience.

[richardlau]

GitHub hosted runners already have a version of Node.js installed so we don't need to use setup-node to install another one to run npx envinfo. PR to remove it: https://github.com/nodejs/node/pull/31349