Node: Node 13.2 segfaults running Jest's tests, 13.1 works

[SimenB]

• Version: 13.2.0
• Platform: Darwin Simens-MacBook-Pro.local 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64 x86_64 (note that this also happens on CI, which is running some Linux version)
• Subsystem:

Upgrading to node 13.2 makes one of jest's test fail with a segfault. 13.1 runs fine. I don't get a stack trace, though, just this: [1] 83292 segmentation fault node packages/jest/bin/jest.js.

To reproduce:

$ git clone [email protected]:facebook/jest.git
$ cd jest
$ yarn # or yarn install-no-ts-build to skip TS compilation and save a couple minutes
$ node -v
v13.1.0
$ node packages/jest/bin/jest.js packages/jest-fake-timers/src/__tests__/fakeTimersLolex.test.ts
$ echo $?
0
$ node -v # after nvm use 13.2.0 or something
v13.2.0
$ node packages/jest/bin/jest.js packages/jest-fake-timers/src/__tests__/fakeTimersLolex.test.ts
[1]    83292 segmentation fault  node packages/jest/bin/jest.js

Note that it's this specific test that fails, other tests seem to run fine. I'm currently bisecting, but I'm on a somewhat limited machine, so it's slow going :)

[Trott]

I'm seeing the same results, but also no segmentation fault when using node compiled from the master branch.

[Trott]

If I did the bisect correctly, the problem is fixed on master in b7b39e0b77d4ad16583ecd56ef5c35b081c9cde4.

[SimenB]

Yep, seems like it: https://github.com/facebook/jest/issues/9244#issuecomment-559994473

I can also confirm that cherry picking just that commit onto the 13.2.0 tag fixes the issue, so I think we can close this.

Thanks!

[sibelius]

is this fixed for node 12?

[Pwndrian]

@sibelius Seems like this won't be fixed in Node 12, as it is blocked by another issue (that won't be fixed in Node 12, neither): https://github.com/nodejs/node/pull/30681