Node: Custom github autolinks

Created on 3 Nov 2019  路  6Comments  路  Source: nodejs/node

Just as a cool thing we could enable: https://help.github.com/en/github/administering-a-repository/configuring-autolinks-to-reference-external-resources, we could have v8:1234 redirect to https://bugs.chromium.org/p/v8/issues/detail?id=1234

meta

Most helpful comment

Done.

Test: v8:9935

All 6 comments

Done.

Test: v8:9935

thanks!

i think this can be left open a bit longer just in case anyone wants any other prefixes.

Maybe autolinks for CI jobs?

CI automatically adds comments to the issue when started, and GitHub references CIs through its "checks" interface, so they are already easy to access. Also, we have dozens of CI jobs, and I don't think build numbers are unique across those jobs, so a single prefix likely wouldn't be enough.

Yeah. I'm just throwing out ideas. How about CITGM, specifically?

That's the one I had in mind when I pitched autolinks for CI. I figured I'd broaden the suggestion in case anyone thought of other CI jobs.

CITGM doesn't show up in the Checks interface, and it's pretty common to have a comment in semver-major PRs that looks like CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1840/. Shortening that to CITGM:1840 would be cool.

node-core-utils currently parses CI links from GitHub comments (including CITGM jobs) so I'd be a bit cautious about autolinking CI jobs.

Was this page helpful?
0 / 5 - 0 ratings