Node: add note in BUILDING.md about running `make distclean`

[bcoe]

• Version: v13.0.0-pre
• Platform: (OSX 10.13.4, Xcode 9.4.1, i5), (Debian GNU/Linux 10, GCC 7.3.0, amd64)

Failure Building Master

I'm receiving the following error when trying to build Node.js on master:

/Users/benjamincoe/bcoe/node/out/Release/obj.target/v8_snapshot/geni/embedded.cc:5:10: fatal error: 'src/snapshot/macros.h' file not found
#include "src/snapshot/macros.h"

I'm receiving this error both on my Debian work desktop and my ancient Macbook.

I also noticed that the same issue was reported by @ronag here.

./configure --without-snapshot

I was able to compile if I configured a build without snapshots, but the ./node bin generated ~segfaults~ fails a check and exits with 1 .

---

CC: @nodejs/build

[bcoe]

This is the exception I get on both systems, if I ./configure --without-snapshot:

Benjamins-MBP-2:node benjamincoe$ ./node 


#
# Fatal error in , line 0
# Check failed: (isolate_->embedded_blob()) != nullptr.
#
#
#
#FailureMessage Object: 0x7ffeefbfe370Illegal instruction: 4

[targos]

I can't reproduce the first issue.

The second one is that apparently the custom Node.js snapshot cannot work without the V8 snapshot, so you have to ./configure --without-snapshot --without-node-snapshot. /cc @joyeecheung

[joyeecheung]

The first issue is usually triggered by some stale build I think. Try doing make distclean (not make clean) and build again, or simply remove the whole thing and build from a fresh clone (make sure you clean you ccache etc. while you are at it)

--without-snapshot is going away soon, as the V8 team is going to remove builds without snapshots, not sure if we should do anything about that.

[bcoe]

@joyeecheung running make distclean worked like a charm on my Linux desktop, I think it might be worth adding a note about to BUILDING.md. I'll leave this open until this evening, and will make an effort to add a note myself.

[AtticusYang]

thank u. I meet the same question.