Node: os.homedir() doesn't respect setuid

[neuroscr]

• Version: v8.10.0
• Platform: Linux 4.15.18-15-pve #1 SMP PVE 4.15.18-40 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: os

Expected os.homedir() to home directory of the current user as a string but when the current user changes via process.setuid() this directory still show the original user's home directory

[Trott]

• Version: v8.10.0
• Platform: Linux 4.15.18-15-pve #1 SMP PVE 4.15.18-40 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: os

Expected os.homedir() to home directory of the _current_ user as a string but when the current user changes via process.setuid() this directory still show the original user's home directory

I understand the expectation, but at the same time, I would expect the opposite behavior--that changing the uid does not affect the home directory. Other languages seem to bear this out. Here's Python being run initially as root and then changing to an unprivileged user with a different home directory:

Python 2.7.10 (default, Feb 22 2019, 21:55:15) 
[GCC 4.2.1 Compatible Apple LLVM 10.0.1 (clang-1001.0.37.14)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> from os.path import expanduser
>>> expanduser("~")
'/var/root'
>>> os.setuid(501)
>>> expanduser("~")
'/var/root'

Perhaps relevant explanation about why sudo preserves the home directory by default rather than adopting the home directory of the privileged user: https://askubuntu.com/a/338449/112895

[neuroscr]

if that's the case, at least the documentation on os.homedir() should be updated to be precise and reflect that; save some other coders some time

(why didn't I think of the ~username trick...)

[juanarbol]

Take a look to his PR #28401

[cclauss]

Did this issue get resolved?

[bnoordhuis]

The PR was merged so yes, this was indeed resolved. Closing, thanks for the ping.