Node: A new label "review wanted"?

[joyeecheung]

I think it would be useful to have a "review wanted" label for PRs that are still looking for reviews. "author ready" is not an exact complement to this, since it can also be applied when there is only one review, but sometimes a PR may want more eyeballs before it lands. This may also be helpful for PRs that have gone in and out of progress due to technical issues or PRs that have been stalled for a while if they want some fresh reviews.

[BridgeAR]

Having that label would be great!

[gireeshpunathil]

great thought! can you please outline the life cycle events of the label? for example anyone including the owner attaches this label when they think this needs one or more reviews? and then detaches when owner or anyone who reviewed decides that the PR got enough reviews?

[joyeecheung]

I guess for most PRs, it goes like: add review wanted -> get approvals -> remove review wanted -> add author ready -> land

For PRs with a longer review cycle: add review wanted -> get reviews (change requests) -> remove review wanted and address reviews -> get approvals -> add author ready -> land.
(Also someone may add author ready early, then some change requests come in, and author ready may be removed until the reviews are addressed.)

For PRs that are trickier, the first review wanted would be add much later than normal PRs, but it helps to signal that this PR is now ready for review.

For PRs that stalled, the review wanted labeled may be added and removed several times during its life time before author ready (if it ever gets there).

[joyeecheung]

OK, I went ahead and created the label https://github.com/nodejs/node/labels/review%20wanted