I was working on porting performance-timeline WPT into core the other day and I realized that it didn't make sense to use the word whatwg in the file name (like what we do to other web-thingy) because performance-timeline is standardized in W3C but not in WHATWG. It sounds reasonable to me to change the whatwg in file names into web as we mostly just use that word to refer to web and it seems somewhat strange to put the name of a working group there in the first place.
I don't think we currently surface the word whatwg in APIs, it's only used to name files under benchmark and test so it should be fine to simply rename those files maintenance-wise.
cc @nodejs/open-standards @jasnell @nodejs/url any thoughts?
joyeecheung
All 7 comments
If the tests comme from from the wpt repository, I suggest to put wpt in the name instead of whatwg or web.
targos
on 4 Dec 2018
@targos The majority of whatwg in file names are of our own tests to Web APIs (in addition to WPT, some pending to be upstreamed, e.g. test-whatwg-url-custom-*), and of benchmarks (legacy-vs-whatwg-*). In the context of WPT drivers in test/wpt I think we can just rename those to something like test-url.js
joyeecheung
on 4 Dec 2018
I think we should keep whatwg for the URL module. That's how it's called in the docs too (The WHATWG URL API)
targos
on 4 Dec 2018
@targos You mean keeping them in the file names, or in the docs, or in general mentioning when we talk about things? I think it's right to keep mentioning WHATWG in docs (and also in comments since we are usually pasting links to whatwg.org anyway), but it seems strange to put those in file names, when we don't put the word w3c in perf_hooks tests..(that'll make the file names look even stranger..)
joyeecheung
on 4 Dec 2018
I wouldn't be confused if we kept whatwg in the name of files related to the WHATWG URL module and used web for others such as perf_hooks. I wouldn't object to renaming them. I just don't feel the need, personally.
targos
on 4 Dec 2018
@targos I see. For now, I think I will just remove the reference of whatwg in test/wpt, since that's where I was hitting the confusion - that also makes the file names more succinct, anyway.
joyeecheung
on 4 Dec 2018
Closing as there's been no activity in quite some time. Can reopen if this is still an issue
jasnell
on 26 Jun 2020
Related issues
loretoparisi
路
3Comments
seishun
路
3Comments
cong88
路
3Comments
jmichae3
路
3Comments
sandeepks1
路
3Comments
Most helpful comment
@targos I see. For now, I think I will just remove the reference of
whatwgintest/wpt, since that's where I was hitting the confusion - that also makes the file names more succinct, anyway.