Node: V8: test-v8 is broken

[refack]

• Version: master
• Platform: several
• Subsystem: V8

Sometime in the last 75h master broke WRT to our V8 test:
(Nov 13, 2018 5:34:00 AM) 7067572a6355acf14cc89abe210e030e84d0d474 ✔️
(Nov 14, 2018 5:34:00 AM) 0e06b350b6d7c80875321531593efc6f273620e5 ❌
(Nov 15, 2018 5:34:00 AM) 3212f77ac6d674a7d43c3303dcca22508c8be468 ❌
(Nov 16, 2018 5:34:00 AM) 8cdb92f11c79de45ed1e7686717bbfc6df304a05 ❌

[refack]

/CC @nodejs/v8 @nodejs/v8-update

[targos]

https://github.com/nodejs/node/pull/24274 was landed on Nov 14 despite a red V8 CI.

[refack]

https://github.com/nodejs/node/compare/7067572a6355acf14cc89abe210e030e84d0d474...0e06b350b6d7c80875321531593efc6f273620e5

[targos]

Error in test compilation:

15:28:41 FAILED: obj/test/cctest/cctest_sources/test-cpu-profiler.o 
15:28:41 ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/test/cctest/cctest_sources/test-cpu-profiler.o.d -DV8_INTL_SUPPORT -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"338452-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DCR_SYSROOT_HASH=815a8c22f8657fe57d02e2c2d893bcdc25a243cf -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE -DENABLE_MINOR_MC -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -DV8_INTL_SUPPORT -DV8_USE_SNAPSHOT -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_CONCURRENT_MARKING -DV8_EMBEDDED_BUILTINS -DV8_TARGET_ARCH_X64 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -I../.. -Igen -I../../include -Igen/include -I../.. -Igen -I../../include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wmissing-field-initializers -Winconsistent-missing-override -Wunreachable-code -Wshorten-64-to-32 -O3 -fno-ident -fdata-sections -ffunction-sections -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../test/cctest/test-cpu-profiler.cc -o obj/test/cctest/cctest_sources/test-cpu-profiler.o
15:28:41 ../../test/cctest/test-cpu-profiler.cc:2574:34: error: use of undeclared identifier 'GetSourcePositionEntryCount'
15:28:41     int non_detailed_positions = GetSourcePositionEntryCount(i_isolate, source);
15:28:41                                  ^
15:28:41 ../../test/cctest/test-cpu-profiler.cc:2579:30: error: use of undeclared identifier 'GetSourcePositionEntryCount'
15:28:41     int detailed_positions = GetSourcePositionEntryCount(i_isolate, source);
15:28:41                              ^
15:28:41 2 errors generated.

[refack]

Opened https://github.com/nodejs/node/pull/24394

[Trott]

Sorry about landing that PR. I saw green CI, approvals, etc. V8 is special and I should have left it to the pros.

[refack]

[refack]

Post land CI shows a failed test:
mjsunit_wasm_jsapi_harness on ppcle-ubuntu1404

stdout:
/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/wasm/jsapi-harness.js:102: Error loading file
load("test/wasm-js/test/harness/wasm-constants.js");
^
Command: /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/out.gn/ppc64.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/wasm/jsapi-harness.js --random-seed=-50650634 --nohard-abort --expose-wasm --allow-natives-syntax

Rerunning: https://ci.nodejs.org/job/node-test-commit-v8-linux/1867/ :x: (fail repetead in job 1867)

/CC @nodejs/v8 @nodejs/platform-ppc

[refack]

Bisect CI on 7067572a6355acf14cc89abe210e030e84d0d474 - https://ci.nodejs.org/job/node-test-commit-v8-linux/1868/

[targos]

Could that be due to a conflict between master and canary? wasm-js isn't gitignored on master so after a canary test run,the files are still there, untracked.

[refack]

We do a git reset --hard && git clean -xdf so supposedly that should be taken can of.
I just wiped all 4 workspaces, and I'm rerunning LKGR:

Bisect:

1. CI on 7067572a6355acf14cc89abe210e030e84d0d474 - https://ci.nodejs.org/job/node-test-commit-v8-linux/1869/ ✔️
2. CI on 6adbe9a9a0ad014b470507de400332075e733b10 - https://ci.nodejs.org/job/node-test-commit-v8-linux/1870/ ✔️

[refack]

Could that be due to a conflict between master and canary?

Above bisect seems to indicate that it is.
I'll see how we can do a better cleanup.

[refack]

So I think I solved the possible conflict issue.
I run the test for canary
https://ci.nodejs.org/job/node-test-commit-v8-linux/1877/ (failed because of https://github.com/nodejs/node-v8/issues/90)
then run master
https://ci.nodejs.org/job/node-test-commit-v8-linux/1878/ ✔️
and it passed, so 🤞 we solved it.