Node: repl: REPL history seems broken in master and v11.2.0

[vsemozhetbyt]

• Version: v11.2.0, v12.0.0-nightly201811153212f77ac6 or 'v12.0.0-v8-canary20181115bc23a47c3b'

• Platform: Windows 7 x64

  * Subsystem: repl

• Delete .node_repl_history.

• Launch node.
• Type:

> 1
1

• Look into .node_repl_history, there is 1 there.
• Type:

> 2
2

• Look into .node_repl_history, there is only 2.
• Type:

> 3
3

• Look into .node_repl_history, there is only 3.
• Type UP ARROW several times. There is only:

> 3

• Close node.
• Look into .node_repl_history, there is only 3 there.

Can anybody reproduce?

[vsemozhetbyt]

I cannot reproduce with v11.1.0.
I can reproduce with v11.2.0.

[vsemozhetbyt]

cc @antsmartian as per possible cause https://github.com/nodejs/node/pull/22153 backported in v11.2.0.

[antsmartian]

@vsemozhetbyt 😢 Yes, thats what caused the regression. My bad.

[antsmartian]

@vsemozhetbyt Working on a PR, on the way. Also, I guess we need to tighten our history test cases, as this should have been caught in first place :( :( .

[caub]

it's still broken in v11.3.0

[vsemozhetbyt]

11.3.0 was a security concerning release, so as per the changelog the fix was not backported yet,

[vsemozhetbyt]

The fix is on v11.x-staging branch, so this may be fixed in the next 11 release.

[RichardBronosky]

I install node via homebrew on macOS. Can someone please explain how I can get this fix?

[caub]

update node

[RichardBronosky]

I have

$ node -v
v11.13.0

and I am still getting this behavior.

[caub]

Oh, it might be a problem on macOS then, for me on v11.13.0 and linux, the problem doesn't exist anymore (it was fixed since v11.4.0 actually)

[RichardBronosky]

I was having a near breakdown from stress and didn't notice the difference between v11.3.0 and v11.13.0. I had for former version and the issue before upgrading to the later but didn't notice the number change and thought I was on the latter from the start. I then went out and bought a OneWheel to burn off some stress.

Thanks for the help though!