I believe that certain versions were not backported to 10.x or 8.x as there was an unexpected semver-major
we can use this issue to track status and backporting
/cc @nodejs/libuv @cjihrig @addaleax
MylesBorins
All 11 comments
Copying https://github.com/nodejs/node/issues/19455#issuecomment-432294763 regarding accidental breaking changes here in case it helps:
I think you're referring to https://github.com/nodejs/node/issues/22814 and https://github.com/nodejs/node/issues/21203. Both of those issues are fixed. A regression test for #22814 landed in https://github.com/nodejs/node/pull/23051. https://github.com/nodejs/node/pull/23053 fixed #21203, but it's marked as don't land on v10 and earlier. Now, that might be backportable since it reverts a semver major and the version of libuv can now be updated on those older branches
cjihrig
on 23 Oct 2018
What Colin said. There were bugs (there are always bugs) but no (edit: deliberately) backwards incompatible changes.
bnoordhuis
on 24 Oct 2018
Just to be clear, is it still the plan to backport updates to libuv to 8.x? I ask because a recent update to libuv on 10.x broke compatibility with older kernels. Relevant commits:
https://github.com/nodejs/node/commit/2790db5e3d74c4f7521cc27a1115228700dd4049
https://github.com/nodejs/node/commit/c65a523597ccdf2b3544244679dae581040cf52f
Does it make sense to introduce this change to 8.x? We've migrated a lot of our services to 8.x since it entered active LTS and this change would force us to roll back hundreds of services to 6.x so that we could continue to get security and stability updates.
I guess my confusion comes from what it means to be "Active LTS." Should these kinds of changes be expected in an active LTS?
AndrewGuenther
on 24 Oct 2018
These changes will only be backported if it can be done in a non breaking
way, that is why it has not yet happened
On Wed, Oct 24, 2018, 12:54 PM Andrew Guenther <[email protected]
wrote:
Just to be clear, is it still the plan to backport updates to libuv to
8.x? I ask because a recent update to libuv on 10.x broke compatibility
with older kernels. Relevant commits:2790db5
https://github.com/nodejs/node/commit/2790db5e3d74c4f7521cc27a1115228700dd4049https://github.com/nodejs/node/blob/c65a523597ccdf2b3544244679dae581040cf52f
Does it make sense to introduce this change to 8.x? We've migrated a lot
of our services to 8.x since it entered active LTS and this change would
force us to roll back hundreds of services to 6.x so that we could continue
to get security and stability updates.I guess my confusion comes from what it means to be "Active LTS." Should
these kinds of changes be expected in an active LTS?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node/issues/23833#issuecomment-432739552, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecVxhAQxBkjwD7Zm8BhqSTLqXgLQ-Zks5uoJtKgaJpZM4X14Vr
.
MylesBorins
on 24 Oct 2018
Excellent. Thanks for the clarification @MylesBorins! So would you say that, in general, we shouldn't have to worry about these kinds of changes during Active LTS?
AndrewGuenther
on 24 Oct 2018
The minimum requirement for v8.x is linux 2.6.32 so no problem there, that's what libuv supports.
v6.x supports 2.6.18 and would be problematic but that's not being discussed, right?
bnoordhuis
on 26 Oct 2018
V6.x is now in maintenance mode and there is no plan to update libuv
On Fri, Oct 26, 2018, 2:58 PM Ben Noordhuis <[email protected] wrote:
The minimum requirement for v8.x is linux 2.6.32 so no problem there,
that's what libuv supports.v6.x supports 2.6.18 and would be problematic but that's not being
discussed, right?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node/issues/23833#issuecomment-433510522, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecVxcbf_utVt_GJFPNt4lPYPxNPZNoks5uo1tWgaJpZM4X14Vr
.
MylesBorins
on 26 Oct 2018
@MylesBorins Should this remain open?
Trott
on 14 Nov 2018
This upgrade has landed in 8.x now and has broken compatibility with older kernels:
https://github.com/nodejs/node/commit/62dd1d7bd48d03324c58a0c8fda3e6a507a95bb0
Systems which could previously run 8.x, which is in LTS, now cannot run 8.x.
AndrewGuenther
on 21 Nov 2018
@andrewguenther can you please open an issue to track this along with a description of how to replicate the breakages. If the broken runtime is with our support matrix we will work on getting a fix out asapc
MylesBorins
on 22 Nov 2018
Will do. Happy Thanksgiving!
AndrewGuenther
on 23 Nov 2018
Related issues
stevenvachon
·
3Comments
jmichae3
·
3Comments
cong88
·
3Comments
vsemozhetbyt
·
3Comments
fanjunzhi
·
3Comments
Most helpful comment
Just to be clear, is it still the plan to backport updates to libuv to 8.x? I ask because a recent update to libuv on 10.x broke compatibility with older kernels. Relevant commits:
https://github.com/nodejs/node/commit/2790db5e3d74c4f7521cc27a1115228700dd4049
https://github.com/nodejs/node/commit/c65a523597ccdf2b3544244679dae581040cf52f
Does it make sense to introduce this change to 8.x? We've migrated a lot of our services to 8.x since it entered active LTS and this change would force us to roll back hundreds of services to 6.x so that we could continue to get security and stability updates.
I guess my confusion comes from what it means to be "Active LTS." Should these kinds of changes be expected in an active LTS?