Node: src\node_buffer.cc:173: Assertion `arg->IsNumber()' failed.

[U-siro]

• Version: v11.0.0-nightly20181007061e09891c

• Platform:
  

• Subsystem:

PS D:\Data\github\nosuelazer2> node server LazerBancho server listening on port 443 LazerBancho NonSecure server listening on port 80 DNS service has started Connected to MySQL, BeatmapHelper will work now vortex.data.microsoft.com ops.dgsrz.com sending49.165.223.140 Windows PowerShell[23292]: src\node_buffer.cc:173: Assertion `arg->IsNumber()' failed. 1: 00007FF78D76B1C5 2: 00007FF78D7443C6 3: 00007FF78D744491 4: 00007FF78D72DEE1 5: 00007FF78D72F069 6: 00007FF78DB6945E 7: 00007FF78DB6A980 8: 00007FF78DB69959 9: 00007FF78DB6983B 10: 000000B88F550861 PS D:\Data\github\nosuelazer2> node -v v11.0.0-nightly20181007061e09891c PS D:\Data\github\nosuelazer2> winver PS D:\Data\github\nosuelazer2>

I tried to use updns npm module, but this error happens.
But It isn't module bugs, because It works correctly on Node v8.
Also It's native error, so I don't have any idea other than bugs.
If It isn't bug, tell me how to fix it. Thanks!

[bzoz]

Could you provide a sample code that reproduces that?

[U-siro]

Better bet is see updns code. @beoz

module.exports.updnsMiddleware = (app, handlers) => {

    app.on('error', error => {
        console.log(error)
    })

    app.on('listening', server => {
        console.log('DNS service has started')
    })

    app.on('message', (domain, send, proxy) => {
        let osuDomains = [
            'android.bugly.qq.com'
        ]
        console.log(domain)
        if(osuDomains.indexOf(domain.toString()) > -1){
            handlers.getIp(null, (osuIp, mirrorIp) => {
                console.log('sending' + osuIp)
                send(osuIp)
            })
        } else {
                proxy('1.1.1.1') // Other traffics
        }
    })
}
let app=updns.createServer(53)
updnsMiddleware(app)

[bzoz]

Yeah, a repro without using updns would be helpful, since most likely this is an issue with the package itself. The same error can be achieved by misusing Buffer API:

Buffer.alloc(1).copy(Buffer.alloc(1), 'err')

[U-siro]

@bzoz Thanks for your comment! However, I think that shouldn't Native error, but a syntax error. :)

[U-siro]

Thanks @addaleax !!

[Trott]

It's unclear to me if this has been fixed or not. Should this remain open?

[cjihrig]

It's not fixed. Please do not close it, I'm working on it.

EDIT: On second though, Rafael's comment below seems to indicate that he is working on it.

[refack]

There's also https://github.com/nodejs/node/issues/23840.