I'd like to nominate George Adams as a collaborator.
He has been active in the CiTGM, Build and core repos over the last year.
PRs in Node core
Comments on Issues and PRs in Node core
PRs in Build WG
Comments on Issues and PRs in Build WG
PRs in CitGM repo
Comments on Issues and PRs in CitGM repo
mhdawson
All 15 comments
@nodejs/collaborators
mhdawson
on 22 Jul 2018
just for clarity, @ChALkeR, @addaleax, @richardlau, @targos, @thefourtheye and @benjamingr have thumbed-up
(for the future, please comment instead of reacting)
devsnek
on 22 Jul 2018
+1
devsnek
on 22 Jul 2018
@devsnek Is there any particular reason you prefer commenting/is this documented somewhere?
addaleax
on 22 Jul 2018
@addaleax after enough people react you have to use the api to see the full list
edit: i'm not trying to say you shouldn't react, just make sure if you want to be explicit that you also comment.
devsnek
on 22 Jul 2018
@devsnek it is unfortunate that it is impossible to +1 without pinging people - I'm also not aware of the process around the +1s at all like Anna. I just thought we were being kind to the nominee and showing we acknowledge their contribution and are 馃憤 on adding them.
In any case - +1
benjamingr
on 22 Jul 2018
+1
ryzokuken
on 22 Jul 2018
+1
mcollina
on 22 Jul 2018
Ok, to be explicit: +1
ChALkeR
on 22 Jul 2018
+1
gireeshpunathil
on 23 Jul 2018
(for the future, please comment instead of reacting)
I'm not against people commenting if they want to explicitly endorse a collaborator nomination, but my person opinion is that a +1 post on its own is just noise, especially since the process around nominations is based on there not being any objections and is not a vote (i.e. the +1's don't influence the outcome of the process):
If there are no objections raised by any Collaborators one week after the issue is opened, the nomination will be considered as accepted. Should there be any objections against the nomination, the TSC is responsible for working with the individuals involved and finding a resolution. The nomination must be approved by the TSC, which is assumed when there are no objections from any TSC members.
https://github.com/nodejs/node/blob/master/GOVERNANCE.md#collaborator-nominations
But in any case since I am commenting +1 from me (with a disclaimer that I work in the same office/team as @gdams at IBM).
richardlau
on 23 Jul 2018
+1
cjihrig
on 23 Jul 2018
+1
trivikr
on 24 Jul 2018
Thanks for the nomination @mhdawson! 馃帀
gdams
on 27 Jul 2018
This happened in https://github.com/nodejs/node/pull/22236.
richardlau
on 10 Aug 2018
Related issues
fanjunzhi
路
3Comments
cong88
路
3Comments
akdor1154
路
3Comments
addaleax
路
3Comments
filipesilvaa
路
3Comments
Most helpful comment
I'm not against people commenting if they want to explicitly endorse a collaborator nomination, but my person opinion is that a
+1post on its own is just noise, especially since the process around nominations is based on there not being any objections and is not a vote (i.e. the+1's don't influence the outcome of the process):https://github.com/nodejs/node/blob/master/GOVERNANCE.md#collaborator-nominations
But in any case since I am commenting +1 from me (with a disclaimer that I work in the same office/team as @gdams at IBM).