node 10.7.0 fails to build - error in traced_value.cc

[kzalewski]

• Version: v10.7.0
• Platform: Linux 4.14.55 x86_64
• Subsystem:

Building node 10.7.0 fails when compiling src/tracing/traced_value.cc with the following error:
../src/tracing/traced_value.cc: In function 'std::string node::tracing::{anonymous}::DoubleToCString(double)': ../src/tracing/traced_value.cc:22:30: error: '__builtin_fpclassify' is not a member of 'std' #define FPCLASSIFY_NAMESPACE std

Adding
#include <cmath>
to the list of include files in traced_value.cc solves the compilation problem.

[ChALkeR]

@kzalewski What complier (and which version) are you using?

[kzalewski]

The compiler is GCC.
Version is 5.5.0.

[ChALkeR]

That falls under supported versions as listed in BUILDING.md.

/cc @nodejs/build, I believe this has a patch attached in the issue.

[jasnell]

Sigh... we really need to make sure CI has full coverage for all of the compiler version combinations we use.

[gibfahn]

Sigh... we really need to make sure CI has full coverage for all of the compiler version combinations we use.

That would be nice, but given the range I'm not sure we'll be able to. @nodejs/build maybe one of each major gcc release at least would be good (or maybe there's a way to work out what releases builders are most likely to have).

GCC 8.1
GCC 7.3
GCC 7.2
GCC 7.1
GCC 6.4
GCC 6.3
GCC 6.2
GCC 6.1
GCC 5.5
GCC 5.4
GCC 5.3
GCC 5.2
GCC 5.1
GCC 4.9.4