Node: failing tests on macos mojave

[devsnek]

test-cluster-bind-privileged-port and test-cluster-shared-handle-bind-privileged-port have been consistently failing for me since i updated to mojave

[Trott]

Can you provide the full output of the test failures?

[devsnek]

=== release test-cluster-shared-handle-bind-privileged-port ===
Path: parallel/test-cluster-shared-handle-bind-privileged-port
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: listen should have failed at test/parallel/test-cluster-shared-handle-bind-privileged-port.js:42
    at Server.mustNotCall (test/common/index.js:533:12)
    at Object.onceWrapper (events.js:273:13)
    at Server.emit (events.js:187:15)
    at emitListeningNT (net.js:1369:10)
    at process._tickCallback (internal/process/next_tick.js:63:19)
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 1
+ 0
    at Worker.<anonymous> (test/parallel/test-cluster-shared-handle-bind-privileged-port.js:38:12)
    at Worker.<anonymous> (test/common/index.js:467:15)
    at Worker.emit (events.js:182:13)
    at ChildProcess.worker.process.once (internal/cluster/master.js:193:12)
    at Object.onceWrapper (events.js:273:13)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
Command: out/Release/node test/parallel/test-cluster-shared-handle-bind-privileged-port.js
=== release test-cluster-bind-privileged-port ===
Path: parallel/test-cluster-bind-privileged-port
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 'EADDRINUSE'
+ 'EACCES'
    at Server.s.on.common.mustCall (test/parallel/test-cluster-bind-privileged-port.js:42:12)
    at Server.<anonymous> (test/common/index.js:467:15)
    at Server.emit (events.js:182:13)
    at listenOnMasterHandle (net.js:1403:21)
    at rr (internal/cluster/child.js:121:12)
    at Worker.send (internal/cluster/child.js:88:7)
    at process.onInternalMessage (internal/cluster/utils.js:42:8)
    at process.emit (events.js:187:15)
    at emit (internal/child_process.js:811:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 1
+ 0
    at Worker.cluster.fork.on.common.mustCall (test/parallel/test-cluster-bind-privileged-port.js:36:12)
    at Worker.<anonymous> (test/common/index.js:467:15)
    at Worker.emit (events.js:182:13)
    at ChildProcess.worker.process.once (internal/cluster/master.js:193:12)
    at Object.onceWrapper (events.js:273:13)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
Command: out/Release/node test/parallel/test-cluster-bind-privileged-port.js
[00:00|% 100|+   0|-   2]: Done

[Trott]

Seems like there's something listening on port 42. Any chance it's a stray node test process that failed to exit from a previous run?

[devsnek]

@Trott actually there was a stray node process running, unfortunately it was not doing anything network related (it was orphaned from my repl prototype)

[Trott]

So the tests are still failing?

If so, what's the output of netstat -vanp tcp | grep '\.42 '?

[devsnek]

@Trott nothing is listening on 42, tests still fail:

$ netstat -vanp tcp | grep '\.42\b'
$ tools/test.py -J test/parallel/test-cluster-*-privileged-port.js | sed -e "s@$(pwd)@@"
=== release test-cluster-bind-privileged-port ===
Path: parallel/test-cluster-bind-privileged-port
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 'EADDRINUSE'
+ 'EACCES'
    at Server.s.on.common.mustCall (/test/parallel/test-cluster-bind-privileged-port.js:42:12)
    at Server.<anonymous> (/test/common/index.js:467:15)
    at Server.emit (events.js:182:13)
    at listenOnMasterHandle (net.js:1403:21)
    at rr (internal/cluster/child.js:121:12)
    at Worker.send (internal/cluster/child.js:88:7)
    at process.onInternalMessage (internal/cluster/utils.js:42:8)
    at process.emit (events.js:187:15)
    at emit (internal/child_process.js:811:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 1
+ 0
    at Worker.cluster.fork.on.common.mustCall (/test/parallel/test-cluster-bind-privileged-port.js:36:12)
    at Worker.<anonymous> (/test/common/index.js:467:15)
    at Worker.emit (events.js:182:13)
    at ChildProcess.worker.process.once (internal/cluster/master.js:193:12)
    at Object.onceWrapper (events.js:273:13)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
Command: out/Release/node /test/parallel/test-cluster-bind-privileged-port.js
=== release test-cluster-shared-handle-bind-privileged-port ===
Path: parallel/test-cluster-shared-handle-bind-privileged-port
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: listen should have failed at /test/parallel/test-cluster-shared-handle-bind-privileged-port.js:42
    at Server.mustNotCall (/test/common/index.js:533:12)
    at Object.onceWrapper (events.js:273:13)
    at Server.emit (events.js:187:15)
    at emitListeningNT (net.js:1369:10)
    at process._tickCallback (internal/process/next_tick.js:63:19)
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual

- 1
+ 0
    at Worker.<anonymous> (/test/parallel/test-cluster-shared-handle-bind-privileged-port.js:38:12)
    at Worker.<anonymous> (/test/common/index.js:467:15)
    at Worker.emit (events.js:182:13)
    at ChildProcess.worker.process.once (internal/cluster/master.js:193:12)
    at Object.onceWrapper (events.js:273:13)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
Command: out/Release/node /test/parallel/test-cluster-shared-handle-bind-privileged-port.js
[00:00|% 100|+   0|-   2]: Done
bash-4.4$

[Trott]

Oooooohhhh.... I see why you're getting EADDRINUSE. It's because the other test is successfully binding on port 42. You can confirm that by running the tests one at a time rather than together. They will likely both still fail but not with the EADDRINUSE that you see in one of the tests above.

Any chance at all that you're running these tests as a non-root user that nonetheless somehow has privileges to bind to port 42? I mean, based on the results, that sure seems like what's going on.

And apologies if the above is all stuff you've already figured out. :-D

[Trott]

Do you get ERROR: Failed to serve: Error: listen EACCES 0.0.0.0:42 when you run npx serve -l 42 /dev/null (or get an error when you otherwise try to set up a server on port 42 without using super-user)?

[devsnek]

@Trott no errors... that's slightly disconcerting. perhaps a rather nasty bug with permissions in mojave?

[Trott]

@devsnek Just to be sure, maybe let's take Node.js out of the equation? Do you get a permission error with python -m SimpleHTTPServer 42?

[devsnek]

@Trott yeah i did some more testing on multiple accounts, etc. mojave has decided that elevation isn't a thing, i assume its a bug.

[devsnek]

i'm not sure if this issue needs to stay open as the bug is with macos not our tests

[Trott]

It can always be re-opened if this is somehow a thing that needs to be worked around.

[jdalton]

I'm able to repro this same issue in macos mojave.

[devsnek]

fwiw i tried to contact apple about this. i think we should skip these tests on macos.

[Trott]

I don't expect it will get us any special results or anything, but I'm going to ping the one @nodejs contributor that I know works at Apple just in case they can help... /ping @gibfahn

[Trott]

Also: @nodejs/platform-macos

[joyeecheung]

I'll remove the CI/flaky test tag since this does not (AFAIK) show up in our CI. I'll add test tag instead.

EDIT: oh, I see the CI tag has been removed

[gdams]

I'm going to work with @mhdawson to add Mojave to our CI.

[Agheb]

As described in https://github.com/nodejs/code-and-learn/issues/86#issuecomment-429397247, we're currently ignoring these test failures for test-cluster-bind-privileged-port and test-cluster-shared-handle-bind-privileged-port on macOS Mojave

[ChALkeR]

Could we version-detect macOS Mojave, perhaps?

[devsnek]

@ChALkeR https://github.com/nodejs/node/pull/23550

[Trott]

I think this should be closed (after a PR is opened to remove the known_issues test, which I'll do right now). Reportedly, Apple has decided that requiring superuser for privileged ports is ineffective security and should be dispensed with. If that is correct, then as far as Apple is concerned, this is a feature and not a bug. Node.js doesn't enforce what ports are privileged. That's up to the OS. So, not a Node.js bug.