Node: Backport Chromium:666046 for Node 6.x

Created on 18 Jun 2018  路  7Comments  路  Source: nodejs/node

Chromium:666046 is a bug known to affect Node 6.x. A fix is available that needs to be back-ported to Node 6.x.

For full details on how we manage the V8 branches in Node release lines see this doc.

V8 Engine help wanted

All 7 comments

/cc @codebytere as you were interested in helping out. This fix itself looks small enough so hopefully the back-port isn't tremendously complicated. I'd be happy to help if you get stuck.

@ofrobots thanks, i'll take a stab at it!

@codebytere seems for me like it's a good change to contribute, isn't it? Are you going to do this or I can take it? (and ping you for a review if you'd like)

Oh, it's already been done:

and landed a while ago. It's weird that this issue seems fresh and the chromium issue doesn't have any updates about it.

@vitkarpov oh you're right, bummer but glad it's been taken care of!

Anything else which could be taken care of? ;) Looking for another issue.

@vitkarpov thanks a lot for taking a look. My bad for losing track of the issue already being fixed in Node 馃槵. I've updated the chromium issue. There are few more issues I am planning to open next week for potential backports, keep an eye on the 'V8 Engine' and 'help wanted' labels.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

willnwhite picture willnwhite  路  3Comments

fanjunzhi picture fanjunzhi  路  3Comments

addaleax picture addaleax  路  3Comments

dfahlander picture dfahlander  路  3Comments

vsemozhetbyt picture vsemozhetbyt  路  3Comments