Node: build: nightly/v8-canary version tag format

[vsemozhetbyt]

Is there a strong reason to glue a date and a commit hash in these tags? Would it be more human-readable to separate them? It would also be easier to copy the hashes for bisect etc.
Compare:

v10.0.0-nightly20180405b29c36b807
v10.0.0-v8-canary20180405bbeda20b90

vs

v10.0.0-nightly20180405-b29c36b807
v10.0.0-v8-canary20180405-bbeda20b90

or even vs

v10.0.0-nightly-2018.04.05-b29c36b807
v10.0.0-v8-canary-2018.04.05-bbeda20b90

[devsnek]

v10.0.0-nightly20180405-b29c36b807
v10.0.0-v8-canary20180405-bbeda20b90

great

v10.0.0-nightly-2018-04-05-b29c36b807
v10.0.0-v8-canary-2018-04-05-bbeda20b90

great

v10.0.0-nightly-2018.04.05-b29c36b807
v10.0.0-v8-canary-2018.04.05-bbeda20b90

[joyeecheung]

cc @nodejs/build I guess to make this happen we would need to take care of some scripts

[rvagg]

There's quite a few dependencies to comb through to make this happen and not break stuff (unlikely that making the change won't involve changing things and seeing what breaks, fixing and repeating).

Off the top of my head:

• https://github.com/nodejs/build/tree/master/setup/www - mainly tools/promote but there may also be logs, metrics and other stuff, someone will need to do a full audit of the config and scripts in there to find anything this touches
• https://github.com/nodejs/nodejs-dist-indexer
• https://github.com/nodejs/nodejs-nightly-builder (maybe)
• https://github.com/nodejs/nodejs-latest-linker (maybe)
• Makefile https://github.com/nodejs/node/blob/master/Makefile#L715 (there may be wider impact than that single line, like the uploading section)
• vcbuild.bat https://github.com/nodejs/node/blob/master/vcbuild.bat#L596 (there may be wider impact than that single line, like the uploading section)
• The iojs+release job in ci-release may need touching

Sorry to be unhelpful but I really don't want to be involved in making a change other than giving suggestions. There's going to be too many things to fix and it's going to fall on the few of us who have access up and down and have a clue how all this stuff pieces together so you'll need to sign up ... actually I'm not sure who else, maybe @gibfahn, @mhdawson or @joaocgreis. It's not something I have anything close to the time required to execute on (I'm picturing the late night scramble sessions as I type this). And (as the person that came up with that format in the first place) I don't see a need to change it, certainly not a need that compares to the pain involved in making the change, picking up the pieces in the aftermath and then maintaining compatibility between two versions going forward (e.g. dist-indexer will need to know about both formats forever).

[vsemozhetbyt]

I see. Well, I will close this for now then)