Node: Adding more teams for cc

[BridgeAR]

Right now there are a couple of teams that are good for cc but there are also multiple concerns without a team and I suggest to create e.g. cluster, child_process, repl, timers, util, zlib, linting, dgram and npm.

Opinions @nodejs/collaborators?

[mcollina]

Definitely +1. We should be mentioning teams and not individuals when asking for reviews.

[joyeecheung]

SGTM

[watilde]

Agreed +1

[richardlau]

+1

We do already have a nodejs/npm team, although it's now down to a single member.

[juggernaut451]

How can one be part of a team?

[BridgeAR]

@juggernaut451 this is only internally for collaborators.

[BridgeAR]

I just created these:

libuv, timers, util, child_process, domains, linting, zlib, repl, cluster and dgram

Please request to join them @nodejs/collaborators

[apapirovski]

I would definitely like to see a team for something like internals or event-loop for stuff like bootstrap, nextTick and overall internal functionality that doesn't easily fall into a good subsystem. I guess it could be process but that seem a bit narrow.

[BridgeAR]

@apapirovski is nextTick not somewhat part of timers?

I think internals is to broad. process would probably be good for bootstrap as well.

[apapirovski]

@apapirovski is nextTick not somewhat part of timers?

It relates more to the event loop than timers. Immediates are also somewhat loosely timers related but at least they only run once per event loop so it makes a bit more sense.

[BridgeAR]

I added process as well now. It should cover process and bootstrap.

[targos]

Those teams should all be children of @nodejs/core

[Trott]

Those teams should all be children of @nodejs/core

Done.

[BridgeAR]

@Trott thanks a lot :-)

@nodejs/collaborators Please from now on always ping the new groups instead of individual users if a group applies.

@apapirovski if you feel like a new group is still necessary, I suggest to add that as well but I think that can be handled separately.

Closing as solved.

[ronkorving]

I have started a thread where collaborators can apply to join teams. Hope it helps.

[gibfahn]

How can one be part of a team?

@juggernaut451 if you keep contributing to Node you will be asked if you'd like to become a collaborator, at which point you can join teams if you want to get pinged for notifications for those issues.

[BridgeAR]

We still miss multiple teams for multiple subsystems, so I went ahead and reopened this.

I just added the following teams:

path, tty, readline, os, events, console, dns and inspector.

@nodejs/collaborators if any of you feels like one of these is a good fit for you, please join the groups!

[targos]

@BridgeAR the teams should be children of the Core team

[BridgeAR]

@targos I do not have the necessary rights to add them to Core on my own but it's requested to be part of that team for all new created teams. Some people should have gotten notifications about these requests :)

[targos]

I'm not sure if anybody received notifications but I found where the requests are listed and accepted them.

[BridgeAR]

Thanks!

[BridgeAR]

I also invited a few people to some groups that I guess might fit.

[benjamingr]

@BridgeAR I've added myself to inspector and events so that hopefully I can help with reviewing PRs related too those topics.

[hiroppy]

@BridgeAR I’m interested in path and console. Could you invite me if possible?

[mcollina]

sgtm

[BridgeAR]

@hiroppy done. @benjamingr I made you the maintainer of the inspector group. It would be great if you could add other people who would like to join (likely @eugeneo).

[benjamingr]

Great, if anyone else wants a ping just feel free to ping me and I'll add you. I signed up too help with reviews mostly since it's most of what I do anyway :]

[eugeneo]

@benjamingr please add @eugeneo and @ak239 to inspector team.

@BridgeAR can @eugeneo and @ak239 be added to the console team? Thanks.

[benjamingr]

@eugeneo you were added to the inspector team. I've also added @ak239 to the inspector team.

[Trott]

Seems like this can be closed now? Re-open if I'm mistaken about that, of course.