Node: Using strict assert in tests

[BridgeAR]

I personally would like to switch our tests to always use the assert strict mode.

I would like to know how other @nodejs/collaborators feel about that.

To reach that we have to change our linting rule to accept the "loose" names if assert was required by the strict property.

And other than that we could create multiple good first contributions with that.

[jasnell]

I'm good with it.

[joyeecheung]

SGTM

[Trott]

Honestly, seems like a lot of churn to me without much benefit.

I'm not sure I like the idea that assert.deepEqual() gets used at all anywhere even if it's behavior is the same as assert.deepStrictEqual() because that won't necessarily be immediately obvious when your hundreds of lines away from where the module was loaded. If you always specify assert.deepStrictEqual(), then you always know what you're getting without having to refer to how the module was loaded.

Also promises to result in lots of merge conflicts on older release lines.

I won't stop this if I'm the only one that feels this way. I don't feel that strongly about it. But on balance, I'm mildly opposed to it.

[mmarchini]

I agree with @Trott, const assert = require('assert').strict; might affect understandability in large files and for new contributors.

[BridgeAR]

Thanks for the feedback. I am closing.