There have been some recent changes in the standards governing our new URL parser API. We need to keep up with those changes in our implementation of the API.
[x] Add space to class string of iterator objects (https://github.com/heycam/webidl/commit/4fcfaeaa3d9ed1141c5f5c75047c2ba2aaa45cea) (#17558)
Change the 'URLSearchParamsIterator' in https://github.com/nodejs/node/blob/e55b7d62863b7eae82e4afccf0b874e0f5ebba16/lib/internal/url.js#L1201 to 'URLSearchParams Iterator', and update tests if necessary.
[x] Percent-encode additional characters in "fragment state" (https://github.com/whatwg/url/commit/7a3c69f8a1583b33e730c3fea85141a618e7c697) (#17627)
FRAGMENT_ENCODE_SET lookup table like https://github.com/nodejs/node/blob/e55b7d62863b7eae82e4afccf0b874e0f5ebba16/src/node_url.cc#L215-L280 but with bits corresponding to 0x20, 0x22, 0x3C, 0x3E, and 0x60 set in additional to what's already set in C0_CONTROL_ENCODE_SET, per spec.C0_CONTROL_ENCODE_SET with the new lookup table under kFragment state in URL::Parse().test/fixtures/url-setter-tests.js and test/fixtures/url-tests.js.doc/api/url.mdI'll handle the first one guys, don't you worry
Shit I really wanted that first one hahaha
Where would the new fragment encode set that we're building be used?
@Kimeiga Glad you decided to take this up! It will be used under case kFragment in the URL::Parse function.
I've completed the first two steps of the second task, but I'm not sure what to do for the third step. Can you lend a hand @TimothyGu ?