Node: meta: commit messages with long URLs

Created on 18 Nov 2017  路  4Comments  路  Source: nodejs/node

Should we alleviate the 72 characters rule for lines with long URLs and note about it in the COLLABORATOR_GUIDE.md?

Example: https://github.com/nodejs/node/pull/17107

Refs: https://github.com/nodejs/core-validate-commit/issues/24

doc meta

Most helpful comment

Should we alleviate the 72 characters rule for lines with long URLs and note about it in the COLLABORATOR_GUIDE.md?

I think this is what we've always done anyway, so why not make it explicit.

All 4 comments

I think there aren't really any workaround for this anyway? This is similar to the ignoreUrls option of max-length in eslint.

@joyeecheung We can use some URL shortener, but this can mess things up.

Should we alleviate the 72 characters rule for lines with long URLs and note about it in the COLLABORATOR_GUIDE.md?

I think this is what we've always done anyway, so why not make it explicit.

+1 to what @gibfahn said.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

willnwhite picture willnwhite  路  3Comments

filipesilvaa picture filipesilvaa  路  3Comments

seishun picture seishun  路  3Comments

ksushilmaurya picture ksushilmaurya  路  3Comments

sandeepks1 picture sandeepks1  路  3Comments