Node: repl: strange regression in output colors

[vsemozhetbyt]

• Version: 8x-9x
• Platform: Windows 7 x64
• Subsystem: util

Compare the outputs of various versions in cmd.exe, pay attention to the string value color:

[addaleax]

@nodejs/platform-windows

[seishun]

The regression was originally introduced in 4fb27d43f0aea39d6e29488ad57903a089ab0a7b. (PR: https://github.com/nodejs/node/pull/9266) cc @srl295

[seishun]

And it was fixed in 90a43906ab5ca8bdf154fb7644d70da9e3acdf00 (PR: https://github.com/nodejs/node/pull/16485), which is semver-major. Not sure how. cc @bnoordhuis

[lance]

Per @seishun notes of the commits, perhaps { colors: true } here is responsible for the fix. And though I don't quite understand why this would change the output formatting, the process.versions property was modified here.

[vsemozhetbyt]

FWIW, the output in v10 (nightly and canary) is colorless as well.

[seishun]

The regression was introduced again in 727339e9c276748d7b4efa066b72e05a1d60a4b9 (PR: https://github.com/nodejs/node/pull/17565). cc @bnoordhuis

[bnoordhuis]

No, the bug that hid the regression was fixed again. :-)

I don't quite understand why this would change the output formatting, the process.versions property was modified here.

Close, it's the custom formatter on this line, which is unnecessary. I'll open a PR.