Node: build: there are two bench phony targets in the makefile

[joyeecheung]

• Version: master
• Subsystem: build

What the title says. One of them should be removed.

https://github.com/nodejs/node/blob/c5a49e148d3293eb9e8c17a15cb8c876977f76af/Makefile#L1121-L1122

[bnoordhuis]

Not really a bug. Multiple .PHONY targets are allowed and even encouraged by some style guides.

Since we're discussing this, maybe it's a good idea to switch to this style:

.PHONY: foo
foo:
        make_foo

.PHONY: bar
bar:
        make_bar

Makes it more obvious it's phony vis-a-vis hiding that fact at the end of the file.

[targos]

Added good first issue label for Ben's suggestion.

[okyantoro]

Hello @targos, @bnoordhuis
Should we make it like:

.PHONY: foo
foo:
        make_foo

.PHONY: bar
bar:
        make_bar

# Redefinition
.PHONY: foo \
  bar

Maybe I can work on this

[bnoordhuis]

@okyantoro Yes, but not the block you labeled 'redefinition.'

[okyantoro]

@bnoordhuis I am still working on this. But I find targets below have no matching target inside Makefile.

bench-http-simple \
  bench-idle \
  blog \
  blogclean \
  dist \
  dynamiclib \
  install-bin \
  install-includes \
  staticlib \
  website-upload

Is it okay to delete these targets?

[bnoordhuis]

@okyantoro Yes, that's fine.

[targos]

Fixed in https://github.com/nodejs/node/pull/17964
Thank you @okyantoro !