Node: What's the deal with `benchmark/misc/v8-bench.js`?

[Trott]

• Version: current master branch
• Platform: n/a
• Subsystem: benchmark

What's the deal with benchmark/misc/v8-bench.js? It does not behave like our other benchmark files. Should it live somewhere else? Should it be deleted?

@nodejs/benchmarking @mscdex

[joyeecheung]

I think this is supposed to be used like this:

1. Run ./node benchmark/misc/v8-bench.js
2. Open deps/v8/benchmarks/run.html
3. Compare the scores of the V8 in Node.js and the V8 in your browser.

I tried to run these V8 benchmarks a few times and the results are pretty flaky. Also the way it's written, it doesn't work with our benchmark suites(run.js, etc.). There seems to be a merit in keeping it though.

[hashseed]

V8 bench is very outdated and has been replaced by Octane years ago.

What is the goal of this benchmark? To ensure that Node.js is on par with Chrome?

[bnoordhuis]

Yes, it was added as a quick gauge.

It can be removed, IMO. We started benchmarking Octane in https://github.com/nodejs/benchmarking/pull/79.

[joyeecheung]

It's been removed in https://github.com/nodejs/node/pull/16126, so closing