Node: http2 - set writable = false when closed = true

Created on 21 Sep 2017  路  5Comments  路  Source: nodejs/node

h2 compat "should" make sure writable === false when closed === true. Though this might cause problems related to https://github.com/nodejs/node/commit/8589c70c85411c2dd0e02c021d926b1954c74696.

http2
Source
picture ronag

Most helpful comment

IMHO we should remove closed from http2 compat.

picture mcollina on 21 Sep 2017
👍3

All 5 comments

@nodejs/http2

benjamingr picture benjamingr on 21 Sep 2017

Ping @mcollina

jasnell picture jasnell on 21 Sep 2017

Not sure if closed is even useful here? Though it might be if we merge https://github.com/nodejs/node/pull/15526.

ronag picture ronag on 21 Sep 2017

IMHO we should remove closed from http2 compat.

mcollina picture mcollina on 21 Sep 2017
👍3

Forgot to add this as "Fixed" note for https://github.com/nodejs/node/pull/15702/files (closed was removed, writable has to stay as is for h1 compatibility)

Could someone close?

apapirovski picture apapirovski on 14 Oct 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jmichae3 picture jmichae3  路  3Comments
filipesilvaa picture filipesilvaa  路  3Comments
Brekmister picture Brekmister  路  3Comments
mcollina picture mcollina  路  3Comments
srl295 picture srl295  路  3Comments