Node: refactor test/inspector

Created on 11 Jun 2017  ·  9Comments  ·  Source: nodejs/node

  • Version: master
  • Platform: all
  • Subsystem: inspector


Especially now that it's not experimental, it seems that it would make sense to:

  • move the tests in test/inspector into test/sequential and/or test/parallel as appropriate
  • move the test/inspector/global-functions.js into test/fixtures
  • move test/inspector-helper.js to test/common/inspector-helper.js

Basically, get rid of the inspector-specific directory.

Or is there real benefit to having it all in its own directory?

@nodejs/testing

inspector test

All 9 comments

Only thing I can think of, is that we don't have enough coverage (cli options https://github.com/nodejs/node/issues/8080 & https://github.com/nodejs/node/pull/13002, new features https://github.com/nodejs/node/pull/11431 & https://github.com/nodejs/node/pull/13228 & https://github.com/nodejs/node/pull/13350) and we are working on merging with /debugger/ https://github.com/nodejs/node/pull/13269
So maybe wait a little while longer?

@refack A rough estimate on when the merging would be done ?

@refack A rough estimate on when the merging would be done?

Hopefully < 1 month 🤷‍♂️

Permission to call dibs now for this ? :P

Permission to call dibs now for this ? :P

I think in general it's a "better to ask forgiveness than permission" situation.
Flagged as in progress.

@adityaanandmc how are you with python?

@refack fairly alright! Plus if all else fails, there is google/duckduckgo to help me out

Do you have something in mind I can help out with ?

Should be able to be closed since #16197 was merged (Refs didn't make it in unfortunately 😞)

(Refs didn't make it in unfortunately 😞)

I think the metadata generator needs the Refs: line to have only the link
image
Also refs doesn't close bugs, only "Fixed:"

Was this page helpful?
0 / 5 - 0 ratings

Related issues

fanjunzhi picture fanjunzhi  ·  3Comments

jmichae3 picture jmichae3  ·  3Comments

seishun picture seishun  ·  3Comments

mcollina picture mcollina  ·  3Comments

dfahlander picture dfahlander  ·  3Comments