Node: test, timers, tools: question about fails on Windows

[vsemozhetbyt]

• Version: mater
• Platform: Windows 7 x64
• Subsystem: test, timers, tools

Sorry, the test is too complicated for me. Is it intended to fail on Windows in both these ways or do I miss some prerequisites or flags?

> Release\node.exe test\timers\test-timers-reliability.js

assert.js:92
  throw new AssertionError({
  ^

AssertionError [ERR_ASSERTION]: false == true
    at Timer.monoTimer.(anonymous function) (test\timers\test-timers-reliability.js:41:3)

> python tools\test.py --mode=release timers

[00:00|%   0|+   0|-   0]: release test-timers-reliability
Traceback (most recent call last):
  File "tools\test.py", line 1730, in <module>
    sys.exit(Main())
  File "tools\test.py", line 1704, in Main
    if RunTestCases(cases_to_run, options.progress, options.j, options.flaky_tests):
  File "tools\test.py", line 920, in RunTestCases
    return progress.Run(tasks)
  File "tools\test.py", line 106, in Run
    self.RunSingle(False, 0)
  File "tools\test.py", line 140, in RunSingle
    output = case.Run()
  File "tools\test.py", line 537, in Run
    "TEST_THREAD_ID": "%d" % self.thread_id
  File "tools\test.py", line 519, in RunCommand
    env)
  File "tools\test.py", line 752, in Execute
    pty_out = pty_out
  File "tools\test.py", line 649, in RunProcess
    **rest
  File "C:\Python27\lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 640, in _execute_child
    startupinfo)
WindowsError: [Error 2]

cc @nodejs/platform-windows, @nodejs/testing, @nodejs/python, @fishrock123, @misterdjules

[Fishrock123]

IIRC you need to install some Faketime tool. I have no idea if it runs on Windows.

The timers directory is specifically for this test and should otherwise not be used.

[misterdjules]

This test does not run on Windows. It uses libfaketime which, at the time I wrote this test, did not support Windows.

[vsemozhetbyt]

Maybe we can somehow note about this, like with the whole pseudo-tty suite:

> python tools\test.py --mode=release pseudo-tty
Skipping pseudo-tty tests, as pseudo terminals are not available on Windows.
No tests to run.

and with isolated tests:

> Release\node.exe test\abort\test-abort-backtrace.js
1..0 # Skipped: Backtraces unimplemented on Windows.

> Release\node.exe test\tick-processor\test-tick-processor-builtin.js
1..0 # Skipped: C++ symbols are not mapped for this os.

[misterdjules]

@vsemozhetbyt Sounds good to me!

[refack]

@vsemozhetbyt you handle with python? Or you need help?

[vsemozhetbyt]

@refack No, I do not handle with python, sorry. Could you please address the python part?

And I actually am not comfortable to mess with a test I do not understand completely, so maybe it would be better if somebody more confident also adds common.skip() or something to the test/timers/test-timers-reliability.js.

[Trott]

Should this remain open?

[vsemozhetbyt]

ping @refack at least for the Python part)

[refack]

Yes. There's an action item here.

[Fishrock123]

This test has since been removed.