Node: meta: beware review comments for long diffs

Created on 20 Apr 2017  路  5Comments  路  Source: nodejs/node

See: https://github.com/nodejs/node/pull/12549#discussion_r112562661

I am not sure if this is a known bug and if we should report it to GitHub.

meta
Source
picture vsemozhetbyt

All 5 comments

I would report it, just to be safe.

jasnell picture jasnell on 21 Apr 2017

I've reported via 'Contact GitHub'. Till fixed, maybe we could split very big docs into several parts for review time.

vsemozhetbyt picture vsemozhetbyt on 21 Apr 2017

Fwiw I also ran into this quite a few times when reviewing the original N-API PR, just describing the location where the comment was supposed to end up worked okay in the end

addaleax picture addaleax on 21 Apr 2017
👍1

GitHub Staff answer:

Thanks for the report! Our team is aware of this issue. I can't promise an ETA for when it might be fixed, but it is on our radar and we'll be sure to write back as soon as we have news.

vsemozhetbyt picture vsemozhetbyt on 21 Apr 2017
👍1

This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

Trott picture Trott on 2 Aug 2017
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

danialkhansari picture danialkhansari  路  3Comments
dfahlander picture dfahlander  路  3Comments
willnwhite picture willnwhite  路  3Comments
cong88 picture cong88  路  3Comments
Icemic picture Icemic  路  3Comments