Node: Possible error with coverage report

[lucamaraschi]

• Version: master
• Platform: all
• Subsystem: test, fs

In the test coverage report line 131 is marked as not covered but a test for this exception/line already exists (https://github.com/nodejs/node/blob/master/test/parallel/test-fs-make-callback.js).

cc: @addaleax && @nodejs/testing

[addaleax]

@lucamaraschi That test uses fs.stat which uses makeStatsCallback, not makeCallback for special callback handling… I think the line is really not covered?

[lucamaraschi]

@addaleax you are indeed right!Gonna open a PR on the test to extend the case also to makeCallback.

[gibfahn]

@lucamaraschi in that case I'll reopen this, and you can close it in your PR!

In case you didn't know, you can add:

Fixes: https://github.com/nodejs/node/issues/12136

to your commit description to auto-close this when your PR lands.

[cjihrig]

@gibfahn I'm not sure that adding coverage for that line of code is related to this issue. This issue was opened for a possible bug in the coverage reporting, but that turned out not to be the case.

[gibfahn]

@cjihrig the way I see it, the issue was raised to ask why that line wasn't being reported as covered. The answer is because the test doesn't cover it, so a PR fixing the test would resolve the issue.