Node: Move V8 inspector to stable

Created on 9 Mar 2017  路  8Comments  路  Source: nodejs/node

The V8 inspector integration is currently considered an experimental feature in the docs.
Now that the debugger is deprecated, I think we should move the V8 inspector to stable and remove the --without-inspector configure flag before Node.js 8 is released.

/cc @nodejs/ctc @nodejs/v8-inspector

discuss inspector

Most helpful comment

I have added https://github.com/nodejs/node/pull/11431 to the 8.0.0 milestone. If we are moving inspector to non-experimental, we should start the inspector, rather than the old debug protocol, on SIGUSR1.

All 8 comments

I agree. We should make it a stable feature. Many people are already relying on it as if it were stable.

I agree that we should make it stable. I am curious as to the reasoning for removing the --without-inspector flag though

I thought the flag was here because of the experimental state of the feature. Is there another reason? Perhaps file size?

I would think file size is good reason. FWIW, we also have a --without-npm flag too, so I personally think we should keep it.

agree it should be stable, and the flag to compile without it should be left in

I have added https://github.com/nodejs/node/pull/11431 to the 8.0.0 milestone. If we are moving inspector to non-experimental, we should start the inspector, rather than the old debug protocol, on SIGUSR1.

Should we pull the runtime part (remove the experimental warning) into @joshgav's PR to update the hint text? https://github.com/nodejs/node/pull/11207

I broke this out into it's own PR https://github.com/nodejs/node/pull/12352

Was this page helpful?
0 / 5 - 0 ratings